pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()
in [PgSql]
|
Prev: [HACKERS] warning message in standby
Next: [HACKERS] pgstatindex still throws ERROR: value "3220078592" is out of range for type integer
From: Fujii Masao on 7 Jun 2010 09:35 On Fri, Jun 4, 2010 at 7:17 AM, Tom Lane <tgl(a)postgresql.org> wrote: > Log Message: > ----------- > Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() result) > and current server clock time to SR data messages. These are not currently > used on the slave side but seem likely to be useful in future, and it'd be > better not to change the SR protocol after release. Per discussion. > Also do some minor code review and cleanup on walsender.c, and improve the > protocol documentation. This commit changed walsender so that it doesn't call set_ps_display() if update_process_title = off. On the other hand, walreceiver doesn't check update_process_title. Though this check might not be required since it's within set_ps_display(), we should do that for the sake of consistency? I attached the patch. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
From: Tom Lane on 7 Jun 2010 11:45
Fujii Masao <masao.fujii(a)gmail.com> writes: > This commit changed walsender so that it doesn't call set_ps_display() if > update_process_title = off. Yeah. The idea is to not waste time on a useless snprintf() call when the GUC is turned off. > On the other hand, walreceiver doesn't check > update_process_title. Though this check might not be required since it's > within set_ps_display(), we should do that for the sake of consistency? Seems reasonable to make the same minor optimization on that side. Will commit. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |