pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
in [PgSql]
|
Prev: Bug? Concurrent COMMENT ON and DROP object
Next: pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
From: Robert Haas on 6 Jul 2010 11:05 On Tue, Jul 6, 2010 at 11:03 AM, Bruce Momjian <bruce(a)momjian.us> wrote: > Robert Haas wrote: >> I think my least favorite option is changing the behavior only in >> HEAD. �I think the reasonable options are: >> >> 1. Change the behavior in HEAD, 8.4, and 8.3, per previous discussion. >> �If we do this, we should do what I proposed in my previous email. >> >> 2. Change the comments and documentation in 8.4 and 8.3 along the >> lines that Simon already did in HEAD. �If we do this, we also need to >> change the GUC units to something other than GUC_UNIT_KB, as noted >> upthread. �I'm not sure what would be appropriate. >> >> The reason I think it's OK to change the behavior in the back-branches >> is that (a) the only thing it affects is logging, so it shouldn't >> really "break" anything, and (b) apparently nobody has noticed that >> the interpretation of the GUC is off by three orders of magnitude, so >> either nobody's using it or they're not looking at what's actually >> happening too carefully. �But I'm OK with going the other way and >> changing the code and docs in the back-branches, too. �I just think we >> should be consistent. > > I normally don't backpatch anything unless it is either a possible cause > of data loss, or a problem that is reported by multiple people. > > Anything backpatched risks causing instability, and might discourage > people from performing minor upgrades. �Minor fixes are rarely worth the > risk of causing instability in back-branches. OK. Well, in that case, I think we should backpatch the changes Simon already made, and also pick a new unit for the GUC. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 6 Jul 2010 19:09 On Tue, Jul 6, 2010 at 5:49 PM, Greg Smith <greg(a)2ndquadrant.com> wrote: > I was never arguing in favor of touching anything in the back branches; if > you recall I didn't even voice an opinion here until I got concerned about > too many changes happening in them. �I think a proper fix in 9.0 combined > with a release notes comment noting the old/new behavior, so it's clear what > was broken in the old versions, would be quite enough here. OK, commit done in head, with a note that we're deliberately not touching the back-branches and should release-note the change. Open item removed, also. > Thanks for following this through, I think it's a useful small bit to get > sorted out fully. yw -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: =?ISO-8859-1?Q?C=E9dric_Villemain?= on 7 Jul 2010 20:32
2010/7/8 Josh Berkus <josh(a)agliodbs.com>: > On 7/6/10 8:06 AM, Tom Lane wrote: >> It might be that nobody's using any values other than 0 and -1 ... >> in which case it wouldn't matter anyway. �I agree that the lack of >> bug reports is notable. �But still, don't we try to avoid behavioral >> changes in stable branches? > > I think most people are doing what I was doing: looking at the values in > the logs, and writing math appropriately. �Most of the other log output > isn't documented well, and the output values are obviously bytes, so > frankly it never occurred to me to check the docs. Samething here > > Agreed that backporting the fix to 8.3 and 8.4 is infeasible. +1 But I don't understand why not backport a documentation patch. Thing is identified, clearly boring for one just trusting the docs. > > -- > � � � � � � � � � � � � � � � � �-- Josh Berkus > � � � � � � � � � � � � � � � � � � PostgreSQL Experts Inc. > � � � � � � � � � � � � � � � � � � http://www.pgexperts.com > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > -- C�dric Villemain 2ndQuadrant http://2ndQuadrant.fr/ PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |