From: Josh Berkus on

>> Shouldn't this be backpatched, or was this a new bug in 9.0?

We've always output bytes. I'd have noticed the discrepancy myself if
I'd read the actual docs ;-)

KB would be more useful. And I don't think people have enough scripts
built on this yet to make this break anything. We should backport to 8.4.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Simon Riggs on
On Fri, 2010-06-25 at 10:56 -0700, Josh Berkus wrote:
> >> Shouldn't this be backpatched, or was this a new bug in 9.0?
>
> We've always output bytes. I'd have noticed the discrepancy myself if
> I'd read the actual docs ;-)

We can still output bytes, no problem. The issue is that the parameter
is actually measured in bytes, whereas the docs say kilobytes, so you
get much more log output than you were expecting.

> KB would be more useful. And I don't think people have enough scripts
> built on this yet to make this break anything. We should backport to 8.4.

OK

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Training and Services


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Josh Berkus on
On 7/6/10 8:06 AM, Tom Lane wrote:
> It might be that nobody's using any values other than 0 and -1 ...
> in which case it wouldn't matter anyway. I agree that the lack of
> bug reports is notable. But still, don't we try to avoid behavioral
> changes in stable branches?

I think most people are doing what I was doing: looking at the values in
the logs, and writing math appropriately. Most of the other log output
isn't documented well, and the output values are obviously bytes, so
frankly it never occurred to me to check the docs.

Agreed that backporting the fix to 8.3 and 8.4 is infeasible.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers