pgsql: In walsender, don't sleep if there's outstanding WAL waiting to
in [PgSql]
|
Prev: [HACKERS] server authentication over Unix-domain sockets
Next: pgsql: In walsender, don't sleep if there's outstandingWAL waiting to
From: Fujii Masao on 31 May 2010 06:03 Hi, On Thu, May 27, 2010 at 7:21 AM, Heikki Linnakangas <heikki(a)postgresql.org> wrote: > Log Message: > ----------- > In walsender, don't sleep if there's outstanding WAL waiting to be sent, > otherwise we effectively rate-limit the streaming as pointed out by > Simon Riggs. Also, send the WAL in smaller chunks, to respond to signals > more promptly. > > Modified Files: > -------------- > pgsql/src/backend/replication: > walsender.c (r1.20 -> r1.21) > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walsender.c?r1=1.20&r2=1.21) This commit seems to have introduced the bug that walsender exits before sending all the WAL up to shutdown checkpoint record when smart shutdown is requested. The attached patch fixes the bug and a tiny typo. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Fujii Masao on 31 May 2010 06:20
On Mon, May 31, 2010 at 7:03 PM, Fujii Masao <masao.fujii(a)gmail.com> wrote: > Hi, > > On Thu, May 27, 2010 at 7:21 AM, Heikki Linnakangas > <heikki(a)postgresql.org> wrote: >> Log Message: >> ----------- >> In walsender, don't sleep if there's outstanding WAL waiting to be sent, >> otherwise we effectively rate-limit the streaming as pointed out by >> Simon Riggs. Also, send the WAL in smaller chunks, to respond to signals >> more promptly. >> >> Modified Files: >> -------------- >> pgsql/src/backend/replication: >> walsender.c (r1.20 -> r1.21) >> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walsender.c?r1=1.20&r2=1.21) > > This commit seems to have introduced the bug that walsender exits > before sending all the WAL up to shutdown checkpoint record when > smart shutdown is requested. > > The attached patch fixes the bug and a tiny typo. Sorry. I forgot to attach the patch.. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center |