pgsql: Make standby server continuously retry restoring the next WAL
in [PgSql]
|
Prev: [HACKERS] pg_restore --single-transaction and --clean
Next: pgsql: Make standby server continuously retry restoringthe next WAL
From: Robert Haas on 25 Mar 2010 09:43 On Thu, Mar 25, 2010 at 8:55 AM, Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> wrote: > * If a corrupt WAL record is found in archive or streamed from master in > standby mode, throw WARNING instead of PANIC, and keep trying. In > archive recovery (ie. standby_mode=off) it's still a PANIC. We can make > it a WARNING too, which gives the pre-9.0 behavior of starting up the > server on corruption. I prefer PANIC but the discussion is still going on. I don't think we should be changing pre-9.0 behavior more than necessary. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Fujii Masao on 26 Mar 2010 01:24 On Thu, Mar 25, 2010 at 9:55 PM, Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> wrote: > * Fix the bug of a spurious PANIC in archive recovery, if the WAL ends > in the middle of a WAL record that continues over a WAL segment boundary. > > * If a corrupt WAL record is found in archive or streamed from master in > standby mode, throw WARNING instead of PANIC, and keep trying. In > archive recovery (ie. standby_mode=off) it's still a PANIC. We can make > it a WARNING too, which gives the pre-9.0 behavior of starting up the > server on corruption. I prefer PANIC but the discussion is still going on. Seems reasonable for me. > * Small code changes to handling of failedSources, inspired by your > comment. No change in functionality. > > This is also available in my git repository at > git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges" I looked the patch and was not able to find any big problems until now. The attached small patch fixes the typo. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
From: Fujii Masao on 30 Mar 2010 22:01
On Wed, Mar 31, 2010 at 1:28 AM, Heikki Linnakangas <heikki.linnakangas(a)enterprisedb.com> wrote: > Fujii Masao wrote: >>> * Small code changes to handling of failedSources, inspired by your >>> comment. No change in functionality. >>> >>> This is also available in my git repository at >>> git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges" >> >> I looked the patch and was not able to find any big problems until now. >> The attached small patch fixes the typo. > > Thanks. Committed with that typo-fix, and I also added a comment > explaining how failedSources and retrying XLogPageRead() works. Great! Thanks a lot! This change affects various recovery patterns that we support now. For example, normal crash recovery, archive recovery, recovery using pg_standby, recovery in standby mode, and so on. So we would need to test whether all of those patterns work fine with the change. I'll do it as much as possible. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |