Prev: [HACKERS] New VACUUM FULL crashes on temp relations
Next: pgsql: Write a WAL record wheneverwe perform an operation without
From: Fujii Masao on 1 Feb 2010 23:40
On Mon, Feb 1, 2010 at 7:40 PM, Heikki Linnakangas
<heikki.linnakangas(a)enterprisedb.com> wrote:
> So you get those messages when the table is *not* a temporary table. I
> can see now what Fujii was trying to say. His patch seems Ok, though
> perhaps it would be better to move the responsibility of calling
> XLogReportUnloggedStatement() to the callers of heap_sync(). When I put
> it in heap_sync(), I didn't take into account that it's sometimes called
> just to flush buffers from buffer cache, not to fsync() non-WAL-logged
> operations.

As you said, I moved the responsibility of calling XLogReportUnloggedStatement()
to the callers of heap_sync(). Here is the patch.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
First  |  Prev  | 
Pages: 1 2
Prev: [HACKERS] New VACUUM FULL crashes on temp relations
Next: pgsql: Write a WAL record wheneverwe perform an operation without