From: Andrea Venturoli on
In Makefile, there's:

..if ${PHP_VER} == 5
USE_PHP+= dom
..else
USE_PHP+= domxml
..endif

However, there is no php52-domxml; should php52-dom be used?

Is the makefile wrong? Should it check for ${PHP_VER}==52?
Or do I need to use some knob?

bye & Thanks
av.
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Alex Keda on
04.05.2010 17:28, Andrea Venturoli пишет:
> In Makefile, there's:
>
> .if ${PHP_VER} == 5
> USE_PHP+= dom
> .else
> USE_PHP+= domxml
> .endif
>
> However, there is no php52-domxml; should php52-dom be used?
>
> Is the makefile wrong? Should it check for ${PHP_VER}==52?
> Or do I need to use some knob?
/usr/ports/textproc/php52-dom

_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Andrea Venturoli on
On 05/05/10 15:15, Alex Keda wrote:
> 05.05.2010 16:08, Andrea Venturoli пишет:
>> On 05/05/10 13:46, Alex Keda wrote:
>>> 04.05.2010 17:28, Andrea Venturoli пишет:
>>>> In Makefile, there's:
>>>>
>>>> .if ${PHP_VER} == 5
>>>> USE_PHP+= dom
>>>> .else
>>>> USE_PHP+= domxml
>>>> .endif
>>>>
>>>> However, there is no php52-domxml; should php52-dom be used?
>>>>
>>>> Is the makefile wrong? Should it check for ${PHP_VER}==52?
>>>> Or do I need to use some knob?
>>> /usr/ports/textproc/php52-dom
>>
>> Ok, thanks.
>> So, would the following be ok in the above Makefile?
>>
>> .if ${PHP_VER} == 4
>> USE_PHP+= domxml
>> .else
>> USE_PHP+= dom
>> .endif
>>
>> If you can confirm this is fine, I could file a PR with the patch.
> I think, it OK

Well, I was beaten on this :-)
Many thanks to Daniel for patching this port.

bye
av.
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"