Prev: Wall time clocks + change in access rules
Next: Resend:videobuf_dma_sg: a new implementation for mmap
From: Stanislaw Gruszka on 30 Jul 2010 07:40
On Fri, 30 Jul 2010 11:57:45 +0200
Tomasz Buchert <tomasz.buchert(a)inria.fr> wrote:

> - read_lock(&tasklist_lock);
> + rcu_read_lock();
> p = find_task_by_vpid(pid);
> if (!p || !(POSIX_CLOCK_PERTHREAD(which_clock) ?
> same_thread_group(p, current) : thread_group_leader(p))) {
> error = -EINVAL;
> }
> - read_unlock(&tasklist_lock);
> + rcu_read_unlock();

IIRC thread_group_leader(p) is wrong here, has_group_leader_pid(p)
should be used. Beside this change alone should be a separate patch,
not part of a "new feature" patch.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Wall time clocks + change in access rules
Next: Resend:videobuf_dma_sg: a new implementation for mmap