power_supply: bq27x00: remove double endian swap
in [Kernel]
|
Prev: power_supply: bq27x00: remove unused struct fields
Next: Is it supposed to be ok to call del_gendisk while userspace is frozen?
From: Rodolfo Giometti on 16 Feb 2010 11:30 On Fri, Feb 12, 2010 at 11:56:46PM +0200, Grazvydas Ignotas wrote: > The bq27x00 registers are little endian, so just read them as such > and don't do double endian swap on LE machines. > > This also gets rid of strange looking shift that was done after > reading 8bit register because endian swap in bq27x00_read() was > messing it up. > > Signed-off-by: Grazvydas Ignotas <notasas(a)gmail.com> Acked-by: Rodolfo Giometti <giometti(a)linux.it> -- GNU/Linux Solutions e-mail: giometti(a)enneenne.com Linux Device Driver giometti(a)linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Anton Vorontsov on 16 Feb 2010 13:40
On Tue, Feb 16, 2010 at 05:22:24PM +0100, Rodolfo Giometti wrote: > On Fri, Feb 12, 2010 at 11:56:46PM +0200, Grazvydas Ignotas wrote: > > The bq27x00 registers are little endian, so just read them as such > > and don't do double endian swap on LE machines. > > > > This also gets rid of strange looking shift that was done after > > reading 8bit register because endian swap in bq27x00_read() was > > messing it up. > > > > Signed-off-by: Grazvydas Ignotas <notasas(a)gmail.com> > > Acked-by: Rodolfo Giometti <giometti(a)linux.it> Patches 1-4 applied. Thanks! -- Anton Vorontsov email: cbouatmailru(a)gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |