powerpc/85xx: Add MChk handler for SRIO port
in [Kernel]
|
Prev: [tip:perf/core] perf tools: Don't keep unreferenced maps when unmaps are detected
Next: linux-next: Tree for August 3
From: Michael Neuling on 3 Aug 2010 02:10 > > MCSR_MASK is not defined anywhere, so when I compile this code, I get this: > > Never mind. I see that it's been fixed already, and that the patch > that removed MCSR_MASK was posted around the same time that this patch > was posted. I don't know what happened here but 2.6.35 is broken because of this problem: arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared (first use in this function) arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier is reported only once arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) arch/powerpc/sysdev/fsl_rio.c:250: error: 'MCSR_BUS_RBERR' undeclared (first use in this function) Mikey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Bounine, Alexandre on 3 Aug 2010 08:30 This happened after change to book-e definitions. There are patches that address this issue. > -----Original Message----- > From: Michael Neuling [mailto:mikey(a)neuling.org] > Sent: Tuesday, August 03, 2010 2:07 AM > To: Timur Tabi > Cc: Alexandre Bounine; linuxppc-dev(a)lists.ozlabs.org; linux-kernel(a)vger.kernel.org; > thomas.moll(a)sysgo.com > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port > > > > MCSR_MASK is not defined anywhere, so when I compile this code, I get this: > > > > Never mind. I see that it's been fixed already, and that the patch > > that removed MCSR_MASK was posted around the same time that this patch > > was posted. > > I don't know what happened here but 2.6.35 is broken because of this > problem: > > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared (first use in this function) > arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier is reported only once > arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) > arch/powerpc/sysdev/fsl_rio.c:250: error: 'MCSR_BUS_RBERR' undeclared (first use in this function) > > Mikey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Timur Tabi on 3 Aug 2010 09:10 On Tue, Aug 3, 2010 at 7:17 AM, Bounine, Alexandre <Alexandre.Bounine(a)idt.com> wrote: > This happened after change to book-e definitions. > There are patches that address this issue. And those patches should have been applied before 2.6.35 was released. Someone dropped the ball. 2.6.35 is broken for a number of PowerPC boards: $ make mpc85xx_defconfig .... $ make .... CC arch/powerpc/sysdev/fsl_rio.o arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared (first use in this function) arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier is reported only once arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1 -- Timur Tabi Linux kernel developer at Freescale -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Bounine, Alexandre on 3 Aug 2010 09:30 Yang Li pointed to these patches in his post from July 23, 2010. It would be nice to have these patches in mainline code. > -----Original Message----- > From: timur.tabi(a)gmail.com [mailto:timur.tabi(a)gmail.com] On Behalf Of Timur Tabi > Sent: Tuesday, August 03, 2010 9:02 AM > To: Bounine, Alexandre > Cc: Michael Neuling; Alexandre Bounine; linuxppc-dev(a)lists.ozlabs.org; linux-kernel(a)vger.kernel.org; > thomas.moll(a)sysgo.com; Kumar Gala > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port > > On Tue, Aug 3, 2010 at 7:17 AM, Bounine, Alexandre > <Alexandre.Bounine(a)idt.com> wrote: > > This happened after change to book-e definitions. > > There are patches that address this issue. > > And those patches should have been applied before 2.6.35 was released. > Someone dropped the ball. 2.6.35 is broken for a number of PowerPC > boards: > > $ make mpc85xx_defconfig > .... > $ make > .... > CC arch/powerpc/sysdev/fsl_rio.o > arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared > (first use in this function) > arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier > is reported only once > arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) > make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1 > > -- > Timur Tabi > Linux kernel developer at Freescale -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michael Neuling on 4 Aug 2010 23:40
In message <0CE8B6BE3C4AD74AB97D9D29BD24E552011430BC(a)CORPEXCH1.na.ads.idt.com> you wrote: > Yang Li pointed to these patches in his post from July 23, 2010. > It would be nice to have these patches in mainline code.=20 This is still broken in Kumar's latest tree. Do you guys wanna repost them so Kumar can pick them up easily? Mikey > > > -----Original Message----- > > From: timur.tabi(a)gmail.com [mailto:timur.tabi(a)gmail.com] On Behalf Of > Timur Tabi > > Sent: Tuesday, August 03, 2010 9:02 AM > > To: Bounine, Alexandre > > Cc: Michael Neuling; Alexandre Bounine; linuxppc-dev(a)lists.ozlabs.org; > linux-kernel(a)vger.kernel.org; > > thomas.moll(a)sysgo.com; Kumar Gala > > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO > port > >=20 > > On Tue, Aug 3, 2010 at 7:17 AM, Bounine, Alexandre > > <Alexandre.Bounine(a)idt.com> wrote: > > > This happened after change to book-e definitions. > > > There are patches that address this issue. > >=20 > > And those patches should have been applied before 2.6.35 was released. > > Someone dropped the ball. 2.6.35 is broken for a number of PowerPC > > boards: > >=20 > > $ make mpc85xx_defconfig > > .... > > $ make > > .... > > CC arch/powerpc/sysdev/fsl_rio.o > > arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': > > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared > > (first use in this function) > > arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier > > is reported only once > > arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears > in.) > > make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1 > >=20 > > -- > > Timur Tabi > > Linux kernel developer at Freescale > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |