proc: turn signal_struct->count into "int nr_threads"
in [Kernel]
|
Prev: sched/cpusets fixes, more changes are needed
Next: Revert "rt: trivial fix to REMINDER block in init/main.c"
From: Oleg Nesterov on 24 Mar 2010 14:20 On 03/24, Oleg Nesterov wrote: > > No functional changes, just s/atomic_t count/int nr_threads/. Argh, I forgot to send "[PATCH 0/1]", please see below... [PATCH -mm 0/1] proc: turn signal_struct->count into "int nr_threads" Depends on [PATCH -mm 1/2] proc_sched_show_task: use get_nr_threads() [PATCH -mm 2/2] keyctl_session_to_parent: use thread_group_empty() to check singlethreadness and on top of the trivial [PATCH -mm] signals-clear-signal-tty-when-the-last-thread-exits.fix I did "make allyesconfig" to test this change, but the compilation failed because of unrelated bugs, and of course "count" is not really grepable :/ However, $ grep -nr --include=*.[ch] -E 'sig\w*->count' */ | grep -Ev 'sigh(and)?->count' kernel/fork.c:827: atomic_set(&sig->count, 1); and this "sig" above is in fact sighand. Fortunately, if I missed some user of signal->count the necessary fix will be really trivial. And I bet in this case that user should be wrong anyway. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Roland McGrath on 9 Apr 2010 16:20
Acked-by: Roland McGrath <roland(a)redhat.com> > It is a bit sad we need a word in struct signal_struct for this, perhaps > we can change get_nr_threads() to approximate the number of threads using > signal->live and kill ->nr_threads later. Agreed. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |