psql \conninfo command (was: Patch: psql \whoami option)
in [PgSql]
|
Prev: psql \conninfo command (was: Patch: psql \whoami option)
Next: [HACKERS] string_to_array has to be stable?
From: David Christensen on 20 Jul 2010 00:16 On Jul 19, 2010, at 11:10 PM, Robert Haas wrote: > On Tue, Jul 20, 2010 at 12:07 AM, Robert Haas <robertmhaas(a)gmail.com> wrote: >> On Tue, Jul 20, 2010 at 12:02 AM, David Christensen <david(a)endpoint.com> wrote: >>>> I would propose to print instead: >>>> >>>> You are connected to database "rhaas" via local socket as user "rhaas". >>> >>> >>> One minor quibble here; you lose the ability to see which pg instance you're running on if there are multiple ones running on different local sockets, so maybe either the port or the socket path should show up here still. >> >> Doh. Will fix. > > Something like the attached? Looks good to me. Regards, David -- David Christensen End Point Corporation david(a)endpoint.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: David Christensen on 21 Jul 2010 22:09
On Jul 21, 2010, at 8:48 PM, Fujii Masao wrote: > On Wed, Jul 21, 2010 at 7:29 PM, Robert Haas <robertmhaas(a)gmail.com> wrote: >> On Wed, Jul 21, 2010 at 1:07 AM, Fujii Masao <masao.fujii(a)gmail.com> wrote: >>> On Tue, Jul 20, 2010 at 11:14 PM, Robert Haas <robertmhaas(a)gmail.com> wrote: >>>> OK, committed. >>> >>> When I specify the path of the directory for the Unix-domain socket >>> as the host, \conninfo doesn't mention that this connection is based >>> on the Unix-domain socket. Is this intentional? >>> >>> $ psql -h"/tmp" -c"\conninfo" >>> You are connected to database "postgres" on host "/tmp" at port "5432" >>> as user "postgres". >>> >>> I expected that something like >>> >>> You are connected to database "postgres" via local socket on >>> "/tmp" at port "5432" as user "postgres". >> >> :-( >> >> No, I didn't realize the host field could be used that way. It's true >> that you get a fairly similar message from \c, but that's not exactly >> intuitive either. >> >> rhaas=# \c - - /tmp - >> You are now connected to database "rhaas" on host "/tmp". > > OK. The attached patch makes \conninfo command emit the following > message if the host begins with a slash: > > $ psql -h/tmp -c"\conninfo" > You are connected to database "postgres" via local socket on > "/tmp" at port "5432" as user "postgres". > > Similarly, it makes \c command emit the following message in that > case: > > $ psql -hlocalhost -c"\c - - /tmp -" > You are now connected to database "postgres" via local socket on "/tmp". If we print the local socket when it's been explicitly set via the host= param, why not display the actual socket path in the general local socket case? Also, while we're still tweaking this patch, I've had a couple requests for the SSL status of the connection as well; does this seem like a generally useful parameter to display as well? Regards, David -- David Christensen End Point Corporation david(a)endpoint.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |