Prev: iwlwifi: use dma_alloc_coherent
Next: [PATCH] UIO: Remove SMX Cryptengine driver
From: David Miller on 10 Feb 2010 14:10
From: "John W. Linville" <linville(a)tuxdriver.com>
Date: Wed, 10 Feb 2010 13:58:16 -0500

> Please let me know if there are problems!

I see one:

> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 5681ebe..03dfd27 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -494,8 +494,7 @@ static int ssb_devices_register(struct ssb_bus *bus)
> #endif
> break;
> case SSB_BUSTYPE_SDIO:
> -#ifdef CONFIG_SSB_SDIO
> - sdev->irq = bus->host_sdio->dev.irq;
> +#ifdef CONFIG_SSB_SDIOHOST
> dev->parent = &bus->host_sdio->dev;
> #endif
> break;

The commit message says "fix a typo" but it's also removing
the assignment of sdev->irq

All the bus types assign the sdev->irq, so it looks like
this was removed unintentionally.

If it was intentional, it needs to be explained in the
commit message or a code comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Johannes Berg on 10 Feb 2010 14:20
On Wed, 2010-02-10 at 11:07 -0800, David Miller wrote:
> From: "John W. Linville" <linville(a)tuxdriver.com>
> Date: Wed, 10 Feb 2010 13:58:16 -0500
>
> > Please let me know if there are problems!
>
> I see one:
>
> > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> > index 5681ebe..03dfd27 100644
> > --- a/drivers/ssb/main.c
> > +++ b/drivers/ssb/main.c
> > @@ -494,8 +494,7 @@ static int ssb_devices_register(struct ssb_bus
> *bus)
> > #endif
> > break;
> > case SSB_BUSTYPE_SDIO:
> > -#ifdef CONFIG_SSB_SDIO
> > - sdev->irq = bus->host_sdio->dev.irq;
> > +#ifdef CONFIG_SSB_SDIOHOST
> > dev->parent = &bus->host_sdio->dev;
> > #endif
> > break;
>
> The commit message says "fix a typo" but it's also removing
> the assignment of sdev->irq
>
> All the bus types assign the sdev->irq, so it looks like
> this was removed unintentionally.
>
> If it was intentional, it needs to be explained in the
> commit message or a code comment.

It was intentional -- that sdev doesn't even have an irq member, but
nobody ever noticed because of the wrong ifdef.

johannes
From: David Miller on 10 Feb 2010 14:40
From: Johannes Berg <johannes(a)sipsolutions.net>
Date: Wed, 10 Feb 2010 20:15:37 +0100

> It was intentional -- that sdev doesn't even have an irq member, but
> nobody ever noticed because of the wrong ifdef.

Ok, then this needs to be explained in the commit message.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 10 Feb 2010 15:30
From: "John W. Linville" <linville(a)tuxdriver.com>
Date: Wed, 10 Feb 2010 15:19:54 -0500

> On Wed, Feb 10, 2010 at 11:36:58AM -0800, David Miller wrote:
>> From: Johannes Berg <johannes(a)sipsolutions.net>
>> Date: Wed, 10 Feb 2010 20:15:37 +0100
>>
>> > It was intentional -- that sdev doesn't even have an irq member, but
>> > nobody ever noticed because of the wrong ifdef.
>>
>> Ok, then this needs to be explained in the commit message.
>
> OK...mind if I just revert the current version and ask Michael to
> resubmit with an appropriate changelog entry?

Have you pulled this tree into others already? Why not
just pop out the commit and fix it's commit message, then
reapply?

Having the revert commit in there is really stupid just for this.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: John W. Linville on 10 Feb 2010 15:30
On Wed, Feb 10, 2010 at 11:36:58AM -0800, David Miller wrote:
> From: Johannes Berg <johannes(a)sipsolutions.net>
> Date: Wed, 10 Feb 2010 20:15:37 +0100
>
> > It was intentional -- that sdev doesn't even have an irq member, but
> > nobody ever noticed because of the wrong ifdef.
>
> Ok, then this needs to be explained in the commit message.

OK...mind if I just revert the current version and ask Michael to
resubmit with an appropriate changelog entry?

John
--
John W. Linville Someday the world will need a hero, and you
linville(a)tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 |  Next  |  Last
Pages: 1 2
Prev: iwlwifi: use dma_alloc_coherent
Next: [PATCH] UIO: Remove SMX Cryptengine driver