quoting psql varible as identifier
in [PgSql]
|
Prev: Port for Microsoft Services for Unix (SFU) or SUA
Next: [HACKERS] solution to make static changes in pg_hba.conf file?
From: Tom Lane on 29 Dec 2009 13:36 Pavel Stehule <pavel.stehule(a)gmail.com> writes: > so we cannot simply implement quote_ident on client side :(. So we > have to use a real query. > It is acceptable for you? No, certainly not --- that adds a boatload of failure conditions. Just quote it unconditionally. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 29 Dec 2009 13:49 On Dec 29, 2009, at 8:57 AM, Pavel Stehule <pavel.stehule(a)gmail.com> wrote: > Hello > > I am working on new patch. I see a problem with copy quote_ident on > client side. This function call ScanKeywordLookup function. > > const ScanKeyword *keyword = ScanKeywordLookup(ident, > > ScanKeywords, > > NumScanKeywords); > > so we cannot simply implement quote_ident on client side :(. So we > have to use a real query. > > It is acceptable for you? No. It has to be client-side. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Pavel Stehule on 29 Dec 2009 13:53 2009/12/29 Tom Lane <tgl(a)sss.pgh.pa.us>: > Pavel Stehule <pavel.stehule(a)gmail.com> writes: >> so we cannot simply implement quote_ident on client side :(. So we >> have to use a real query. > >> It is acceptable for you? > > No, certainly not --- that adds a boatload of failure conditions. > Just quote it unconditionally. ok this function have to live in libpq - it needs some not exported functionality. But, it would not be a problem. Pavel > > Â Â Â Â Â Â Â Â Â Â Â Â regards, tom lane > -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Alvaro Herrera on 29 Dec 2009 14:46 Pavel Stehule escribi�: > 2009/12/29 Tom Lane <tgl(a)sss.pgh.pa.us>: > > Pavel Stehule <pavel.stehule(a)gmail.com> writes: > >> so we cannot simply implement quote_ident on client side :(. So we > >> have to use a real query. > > > >> It is acceptable for you? > > > > No, certainly not --- that adds a boatload of failure conditions. > > Just quote it unconditionally. > > ok > > this function have to live in libpq - it needs some not exported > functionality. But, it would not be a problem. Can we use a trick similar to pg_dump's? -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Pavel Stehule on 29 Dec 2009 14:47
2009/12/29 Alvaro Herrera <alvherre(a)commandprompt.com>: > Pavel Stehule escribió: >> 2009/12/29 Tom Lane <tgl(a)sss.pgh.pa.us>: >> > Pavel Stehule <pavel.stehule(a)gmail.com> writes: >> >> so we cannot simply implement quote_ident on client side :(. So we >> >> have to use a real query. >> > >> >> It is acceptable for you? >> > >> > No, certainly not --- that adds a boatload of failure conditions. >> > Just quote it unconditionally. >> >> ok >> >> this function have to live in libpq - it needs some not exported >> functionality. But, it would not be a problem. > > Can we use a trick similar to pg_dump's? ?? Pavel > > -- > Alvaro Herrera                 http://www.CommandPrompt.com/ > PostgreSQL Replication, Consulting, Custom Development, 24x7 support > -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |