r852: remove casts from void*
in [Kernel]
|
From: Dan Carpenter on 29 Jun 2010 08:50 On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote: > Remove unnesessary casts from void*. > 1) The subjects are not helpful. This one should say something about "mtd" but it doesn't. 2) These haven't been run through checkpatch.pl. In fact, I can't be certain anyone looked at these patches when I see things like: - if((( lp = (struct wl_private *)dev->priv ) != NULL ) && - !( lp->flags & WVLAN2_UIL_BUSY )) { + if((( lp = dev->priv ) != NULL ) && + !( lp->flags & WVLAN2_UIL_BUSY )) { On the recieving end, someone has to review every patch that gets merged. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: walter harms on 29 Jun 2010 09:00 Dan Carpenter schrieb: > On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote: >> Remove unnesessary casts from void*. >> > > 1) The subjects are not helpful. This one should say something about > "mtd" but it doesn't. > 2) These haven't been run through checkpatch.pl. In fact, I can't be > certain anyone looked at these patches when I see things like: > > - if((( lp = (struct wl_private *)dev->priv ) != NULL ) && > - !( lp->flags & WVLAN2_UIL_BUSY )) { > + if((( lp = dev->priv ) != NULL ) && > + !( lp->flags & WVLAN2_UIL_BUSY )) { > > On the recieving end, someone has to review every patch that gets merged. > same problem in drivers/scsi/sg.c but that would requiere a additional patch. re, wh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Kulikov Vasiliy on 29 Jun 2010 11:30 > 1) The subjects are not helpful. This one should say something about > "mtd" but it doesn't. ok > 2) These haven't been run through checkpatch.pl. Sorry for dummy question, but shouldn't code style be consistent? Somebody who will see old code and patched code will see one line with wrong-style code then one line with ok then one with wrong etc. Imho it's better to fix style in one big patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dan Carpenter on 29 Jun 2010 15:10 On Tue, Jun 29, 2010 at 07:28:26PM +0400, Kulikov Vasiliy wrote: > > 1) The subjects are not helpful. This one should say something about > > "mtd" but it doesn't. > ok > > > 2) These haven't been run through checkpatch.pl. > Sorry for dummy question, but shouldn't code style be consistent? > Somebody who will see old code and patched code will see one line with > wrong-style code then one line with ok then one with wrong etc. > Imho it's better to fix style in one big patch. No. If there's only one good line in a whole file, that's at least better than nothing. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Artem Bityutskiy on 13 Jul 2010 06:30 On Tue, 2010-06-29 at 14:14 +0400, Kulikov Vasiliy wrote: > Remove unnesessary casts from void*. > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> Pushed whole series to l2-mtd-2.6.git / master. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: Documentation: fix ubuntu distro name Next: trace-cmd: Add to ignore event not found error |