regulator: max1586 - fix a memory leak in max1586_pmic_remove()
in [Kernel]
|
Prev: regulator: max8660 - fix a memory leak in max8660_remove()
Next: [GIT PULL] arch/cris changes for 2.6.36
From: Wolfram Sang on 6 Aug 2010 04:50 On Fri, Aug 06, 2010 at 01:33:15PM +0800, Axel Lin wrote: > In max1586_pmic_probe(), we allocate memory for max1586. > In max1586_pmic_remove(), current implementation only free rdev > which is a member of struct max1586_data. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max1586 to i2c clientdata, > and properly kfree(max1586) in max1586_pmic_remove(). > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Like with the max8660-patch: Acked-by: Wolfram Sang <w.sang(a)pengutronix.de> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
From: Mark Brown on 6 Aug 2010 07:20 On Fri, Aug 06, 2010 at 01:33:15PM +0800, Axel Lin wrote: > In max1586_pmic_probe(), we allocate memory for max1586. > In max1586_pmic_remove(), current implementation only free rdev > which is a member of struct max1586_data. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max1586 to i2c clientdata, > and properly kfree(max1586) in max1586_pmic_remove(). > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on 9 Aug 2010 04:30
On Fri, 2010-08-06 at 13:33 +0800, Axel Lin wrote: > In max1586_pmic_probe(), we allocate memory for max1586. > In max1586_pmic_remove(), current implementation only free rdev > which is a member of struct max1586_data. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max1586 to i2c clientdata, > and properly kfree(max1586) in max1586_pmic_remove(). > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> > --- > drivers/regulator/max1586.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |