From: Mike Frysinger on
On Mon, Jun 7, 2010 at 08:28, Mark Brown wrote:
> On Fri, Jun 04, 2010 at 12:40:46PM +0800, sonic zhang wrote:
>> +static int __init ad5398_init(void)
>> +{
>> +     return i2c_add_driver(&ad5398_driver);
>> +}
>> +module_init(ad5398_init);
>
> at least some systems are likely to want this to be subsys_initcall() to
> make sure the regulator is available prior to the consumers.  Please
> send an incremental change for this rather than repostnig the full
> thing.

i guess the Blackfin I2C driver should have its initcall bumped up as well
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on
On Fri, 2010-06-04 at 12:40 +0800, sonic zhang wrote:
> >From 32646efc2e7fb19945a10ad3f1172d6f751186b8 Mon Sep 17 00:00:00 2001
> From: Sonic Zhang <sonic.zhang(a)analog.com>
> Date: Fri, 4 Jun 2010 11:46:04 +0800
> Subject: [PATCH v6] regulator: new drivers for AD5398 and AD5821
>
> The AD5398 and AD5821 are single 10-bit DAC with 120 mA output current
> sink capability. They feature an internal reference and operates from
> a single 2.7 V to 5.5 V supply.
>
> This driver supports both the AD5398 and the AD5821. It adapts into the
> voltage and current framework.
>
> Signed-off-by: Sonic Zhang <sonic.zhang(a)analog.com>
> Signed-off-by: Mike Frysinger <vapier(a)gentoo.org>
> ---
> drivers/regulator/Kconfig | 6 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/ad5398.c | 288 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 295 insertions(+), 0 deletions(-)
> create mode 100644 drivers/regulator/ad5398.c
>

Applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/