Prev: Row-level Locks & SERIALIZABLE transactions, postgres vs. Oracle
Next: [HACKERS] message style for errcontext
From: Tom Lane on 17 May 2010 11:34
Andrew Dunstan <andrew(a)dunslane.net> writes:
> Why do the release notes say this, under plperl:
> * PL/Perl subroutines are now given names (Tim Bunce)
> This is for the use of profiling and code coverage tools. DIDN'T
> THEY HAVE NAMES BEFORE?

> If whoever put this in the release notes had bothered to ask I am sure
> we would have been happy to explain.

You don't need to complain, just fix it. The point of the comment is
that more explanation is needed.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Andrew Dunstan on 17 May 2010 12:19


Tom Lane wrote:
> Andrew Dunstan <andrew(a)dunslane.net> writes:
>
>> Why do the release notes say this, under plperl:
>> * PL/Perl subroutines are now given names (Tim Bunce)
>> This is for the use of profiling and code coverage tools. DIDN'T
>> THEY HAVE NAMES BEFORE?
>>
>
>
>> If whoever put this in the release notes had bothered to ask I am sure
>> we would have been happy to explain.
>>
>
> You don't need to complain, just fix it. The point of the comment is
> that more explanation is needed.
>
>
>

OK ... I guess I was bothered because this has been referred to in a
public press release about the Beta. The PLPerl security stuff is
missing too, so I'll fix that also.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on 17 May 2010 12:28
Andrew Dunstan <andrew(a)dunslane.net> writes:
> OK ... I guess I was bothered because this has been referred to in a
> public press release about the Beta. The PLPerl security stuff is
> missing too, so I'll fix that also.

The security stuff isn't relevant to the 9.0 notes, since it's already
been fixed in a previous release. In general we don't document bug
fixes in a major release if they already appeared in previous
back-patches; the major release notes are quite verbose enough without
such duplication. (In effect, the idea is that major release notes
should represent the delta from the previous major release *as it stood
at the time of the new major release*.)

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Andrew Dunstan on 17 May 2010 12:36


Tom Lane wrote:
> Andrew Dunstan <andrew(a)dunslane.net> writes:
>
>> OK ... I guess I was bothered because this has been referred to in a
>> public press release about the Beta. The PLPerl security stuff is
>> missing too, so I'll fix that also.
>>
>
> The security stuff isn't relevant to the 9.0 notes, since it's already
> been fixed in a previous release. In general we don't document bug
> fixes in a major release if they already appeared in previous
> back-patches; the major release notes are quite verbose enough without
> such duplication. (In effect, the idea is that major release notes
> should represent the delta from the previous major release *as it stood
> at the time of the new major release*.)
>


OK, then I will just remove the now redundant item regarding Safe.pm.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tim Bunce on 22 May 2010 14:07
On Mon, May 17, 2010 at 11:34:37AM -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(a)dunslane.net> writes:
> > Why do the release notes say this, under plperl:
> > * PL/Perl subroutines are now given names (Tim Bunce)
> > This is for the use of profiling and code coverage tools. DIDN'T
> > THEY HAVE NAMES BEFORE?
>
> > If whoever put this in the release notes had bothered to ask I am sure
> > we would have been happy to explain.
>
> You don't need to complain, just fix it. The point of the comment is
> that more explanation is needed.

I think you can just delete it. It's too esoteric to be worth noting.

Tim.

p.s. It also turned to be insufficiently useful for NYTProf since it
doesn't also update some internals to record the 'filename' and line
number range of the sub. So PostgreSQL::PLPerl::NYTProf works around
that by wrapping mkfuncsrc() to edit the generated perl code to include
a subname in the usual "sub $name { ... }" style. I may offer a patch
for 9.1 to to make it work that way.

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 |  Next  |  Last
Pages: 1 2
Prev: Row-level Locks & SERIALIZABLE transactions, postgres vs. Oracle
Next: [HACKERS] message style for errcontext