remove all rcu head initializations, except on_stack initializations
in [Kernel]
|
Prev: [PATCH tip/core/rcu 01/48] rcu: optionally leave lockdep enabled after RCU lockdep splat
Next: [PATCH tip/core/rcu 39/48] notifiers: __rcu annotations
From: Matt Mackall on 4 May 2010 16:30 On Tue, 2010-05-04 at 13:19 -0700, Paul E. McKenney wrote: > From: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com> > > Remove all rcu head inits. We don't care about the RCU head state before passing > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can > keep track of objects on stack. Please document that distinction at the definition of INIT_RCU_HEADS, otherwise we're sure to see creep. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Paul E. McKenney on 4 May 2010 16:40 On Tue, May 04, 2010 at 03:27:03PM -0500, Matt Mackall wrote: > On Tue, 2010-05-04 at 13:19 -0700, Paul E. McKenney wrote: > > From: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com> > > > > Remove all rcu head inits. We don't care about the RCU head state before passing > > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can > > keep track of objects on stack. > > Please document that distinction at the definition of INIT_RCU_HEADS, > otherwise we're sure to see creep. Hello, Matt, RCU_HEAD_INIT() is no more. Or will be no more after this patchset. However, now that you mention it, we do need docbook comments for init_rcu_head_on_stack() and friends. I will fix that. Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Paul E. McKenney on 4 May 2010 20:10
On Wed, May 05, 2010 at 09:44:56AM +1000, James Morris wrote: > On Tue, 4 May 2010, Paul E. McKenney wrote: > > > From: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com> > > > > Remove all rcu head inits. We don't care about the RCU head state before passing > > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can > > keep track of objects on stack. > > > > This patch applies to current -tip based on 2.6.34-rc2. > > Reviewed-by: James Morris <jmorris(a)namei.org> Thank you, James! Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |