remove q->prepare_flush_fn hook
in [Kernel]
|
Prev: [PATCH 3/9] scsi: stop using q->prepare_flush_fn
Next: hwmon: Add support for W83667HG-B and W83667HG-I to w83627ehf driver.
From: Christoph Hellwig on 3 Jul 2010 06:10 On Sat, Jul 03, 2010 at 05:45:31PM +0900, FUJITA Tomonori wrote: > This removes q->prepare_flush_fn. Except for ide and scsi, all the > users just mark flush requests. They can use REQ_FLUSH flag > instead. > > SCSI and ide can use q->prep_rq_fn to build flush requests. > > This can be applied to the block's for-2.6.36. The whole patchset looks good to me, Reviewed-by: Christoph Hellwig <hch(a)lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jens Axboe on 5 Jul 2010 03:00 On 2010-07-03 10:45, FUJITA Tomonori wrote: > This removes q->prepare_flush_fn. Except for ide and scsi, all the > users just mark flush requests. They can use REQ_FLUSH flag > instead. > > SCSI and ide can use q->prep_rq_fn to build flush requests. > > This can be applied to the block's for-2.6.36. Thanks, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jens Axboe on 5 Jul 2010 04:10 On 2010-07-05 10:01, FUJITA Tomonori wrote: > On Mon, 05 Jul 2010 08:55:36 +0200 > Jens Axboe <axboe(a)kernel.dk> wrote: > >> On 2010-07-03 10:45, FUJITA Tomonori wrote: >>> This removes q->prepare_flush_fn. Except for ide and scsi, all the >>> users just mark flush requests. They can use REQ_FLUSH flag >>> instead. >>> >>> SCSI and ide can use q->prep_rq_fn to build flush requests. >>> >>> This can be applied to the block's for-2.6.36. >> >> Thanks, applied. > > Thanks, > > looks like you applied the patches in a wrong order (breaks bisect). > > At least, the first two patches need to be applied in order before the > rest: > > [PATCH 1/9] block: introduce REQ_FLUSH flag > [PATCH 2/9] block: permit PREFLUSH and POSTFLUSH without prepare_flush_fn Funky, my patch script must have shuffled them, that was definitely not on purpose. Guess I'll have to rebase to fix that up... -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: FUJITA Tomonori on 5 Jul 2010 04:10 On Mon, 05 Jul 2010 08:55:36 +0200 Jens Axboe <axboe(a)kernel.dk> wrote: > On 2010-07-03 10:45, FUJITA Tomonori wrote: > > This removes q->prepare_flush_fn. Except for ide and scsi, all the > > users just mark flush requests. They can use REQ_FLUSH flag > > instead. > > > > SCSI and ide can use q->prep_rq_fn to build flush requests. > > > > This can be applied to the block's for-2.6.36. > > Thanks, applied. Thanks, looks like you applied the patches in a wrong order (breaks bisect). At least, the first two patches need to be applied in order before the rest: [PATCH 1/9] block: introduce REQ_FLUSH flag [PATCH 2/9] block: permit PREFLUSH and POSTFLUSH without prepare_flush_fn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on 7 Jul 2010 16:00
One weird thing after this set is that the flush commands don't have any cmd_type. I think it should be set to REQ_TYPE_FS, even if we might be resetting it inside the driver for now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |