Prev: rwsem: wake queued readers when writer blocks on active read lock
Next: generic rwsem: implement down_read_unfair
From: David Howells on 12 May 2010 08:40

Have you tried compiling this patch?

lib/rwsem.c: In function 'rwsem_down_failed_common':
lib/rwsem.c:177: error: invalid type argument of '->' (have 'struct rwsem_waiter')

There's a list_add_tail() that refers to waiter->list

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Howells on 12 May 2010 08:50
Michel Lespinasse <walken(a)google.com> wrote:

> Following change also enjoys having flags available in a register rather
> than having to fish it out in the struct rwsem_waiter...

So what? It doesn't use flags in rwsem_down_failed_common().

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Michel Lespinasse on 12 May 2010 23:00
On Wed, May 12, 2010 at 5:42 AM, David Howells <dhowells(a)redhat.com> wrote:
> Michel Lespinasse <walken(a)google.com> wrote:
>
>> Following change also enjoys having flags available in a register rather
>> than having to fish it out in the struct rwsem_waiter...
>
> So what? �It doesn't use flags in rwsem_down_failed_common().

I meant patch 10 wants to use the flags in order to know whether to
queue at the head or tail of the waiter list.

Apologies for the compile error, patches 8 and 10 used to be a single
change and were split off relatively late. :/

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Howells on 19 May 2010 09:00

Michel Lespinasse <walken(a)google.com> wrote:

> More code can be pushed from rwsem_down_read_failed and
> rwsem_down_write_failed into rwsem_down_failed_common.
>
> Following change adding down_read_unfair infrastructure support also
> enjoys having flags available in a register rather than having to
> fish it out in the struct rwsem_waiter...
>
> Signed-off-by: Michel Lespinasse <walken(a)google.com>

Acked-by: David Howells <dhowells(a)redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: rwsem: wake queued readers when writer blocks on active read lock
Next: generic rwsem: implement down_read_unfair