Prev: *ERROR* i915_do_wait_request
Next: 3c59x: Add ethtool WOL support
From: Hari Kanigeri on 25 Jul 2010 14:40
> +config ENABLE_OFF_MODE_JTAG_ETM_DEBUG
> + � � � bool "Enable hardware emulation context save and restore"
> + � � � depends on ARCH_OMAP3

-- Shouldn't this be depends on OMAP3_EMU instead ?

> + � � � default y

-- As this is debug option, can you keep this "n" by default ?

> + � � � help
> + � � � � This option enables JTAG & ETM debugging across power states.
> + � � � � With out this option emulation features are reset across OFF
> + � � � � mode state changes.
> +

Hari
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Alexander Shishkin on 25 Jul 2010 15:50
On Sun, Jul 25, 2010 at 12:34:22 -0600, Hari Kanigeri wrote:
> > +config ENABLE_OFF_MODE_JTAG_ETM_DEBUG
> > + � � � bool "Enable hardware emulation context save and restore"
> > + � � � depends on ARCH_OMAP3
>
> -- Shouldn't this be depends on OMAP3_EMU instead ?

Not really. OMAP3_EMU will enable ETM/ETB drivers within omap, but this
particular patch is also needed if you're using an external hardware
debugger to debug code across OFF modes.

> > + � � � default y
>
> -- As this is debug option, can you keep this "n" by default ?

This option allows for enabling certain debugging functionality in runtime
(via a sysfs file), which is turned off by default. It is debatable whether
this option should default to 'y' or 'n', seeing as it doesn't add much
overhead to the normal usecase.

> > + � � � help
> > + � � � � This option enables JTAG & ETM debugging across power states.
> > + � � � � With out this option emulation features are reset across OFF
> > + � � � � mode state changes.

But I see that the wording is misleading and unclear, so I'll try to come
up with something more descriptive.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Alexander Shishkin on 30 Jul 2010 08:20
On Sun, Jul 25, 2010 at 08:05:19 +0300, Alexander Shishkin wrote:
> This prevents ETM stalls whenever core enters OFF mode. Original patch
> author is Richard Woodruff <r-woodruff2(a)ti.com>.
>
> This version of the patch makes use of the ETM OS save/restore mechanism,
> which takes about 55 words in omap3_arm_context[] instead of 128. Also,
> saving ETM context can be switched on/off at runtime.

Can I have some (n)acks on this one and 7/7 as well?

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: *ERROR* i915_do_wait_request
Next: 3c59x: Add ethtool WOL support