scripts: checkpatch.pl
in [Kernel]
|
Prev: [PATCH] sanitize task->comm to avoid leaking escape codes
Next: sanitize task->comm to avoid leaking escape codes
From: Andrew Morton on 23 Jun 2010 15:30 On Wed, 23 Jun 2010 11:49:21 +0200 Raffaele Recalcati <lamiaposta71(a)gmail.com> wrote: > From: Raffaele Recalcati <raffaele.recalcati(a)bticino.it> > > I've got a false positive when spaces are present > at the beginning of a line. > So I add this check, obviously outside comments. > This patch is compatible with the actual mainline, > I mean 7e27d6e778cd87b6f2415515d7127eba53fe5d02 commit. I don't really understand that. It would help if the changelog were to include a copy of the code which triggers this "false positive", and a copy of the incorrect checkpatch output. Thanks. > Signed-off-by: Raffaele Recalcati <raffaele.recalcati(a)bticino.it> > --- > scripts/checkpatch.pl | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index a4d7434..315a827 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1433,6 +1433,13 @@ sub process { > WARN("please, no space before tabs\n" . $herevet); > } > > +# check for spaces at the beginning of a line. > + if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/) { > + my $herevet = "$here\n" . cat_vet($rawline) . "\n"; > + WARN("please, no space for starting a line, \ > + excluding comments\n" . $herevet); > + } > + > # check we are in a valid C source file if not then ignore this hunk > next if ($realfile !~ /\.(h|c)$/); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |