should I post the patch as committed?
in [PgSql]
|
Prev: [HACKERS] Why does TRIM() expect an expr_list?
Next: BUG #4887: inclusion operator (@>)on tsqeries behaves not conforming to documentation
From: Tom Lane on 20 Apr 2010 12:30 Robert Haas <robertmhaas(a)gmail.com> writes: > Bruce suggested to me off-list that when I commit a patch with > revisions, I ought to attach the committed patch to the email in which > I say that I have committed it. I know that Bruce habitually does > this, but I've never found it very helpful, since I prefer to look at > the patch either using the pgsql-committers emails or the git > respository. I quite agree --- people who want to read the committed patch are going to go to the source, not to what somebody claims he committed. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 20 Apr 2010 13:04 On Tue, Apr 20, 2010 at 18:30, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas(a)gmail.com> writes: >> Bruce suggested to me off-list that when I commit a patch with >> revisions, I ought to attach the committed patch to the email in which >> I say that I have committed it. I know that Bruce habitually does >> this, but I've never found it very helpful, since I prefer to look at >> the patch either using the pgsql-committers emails or the git >> respository. > > I quite agree --- people who want to read the committed patch are going > to go to the source, not to what somebody claims he committed. Yeah, +1. I always go to one of the other sources (most of the time, the gitweb or git server). It doesn't hurt to attach it if it happens to be around, but I wouldn't suggest spending any extra effort on it... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "Kevin Grittner" on 20 Apr 2010 13:07 Robert Haas <robertmhaas(a)gmail.com> wrote: > is it helpful to attach the patch-as-committed to the -hackers > email, or is it just duplicative of what's already available > elsewhere? I'm fine with using git.postgresql.org to see what was committed. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Bruce Momjian on 20 Apr 2010 13:07 Magnus Hagander wrote: > On Tue, Apr 20, 2010 at 18:30, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > > Robert Haas <robertmhaas(a)gmail.com> writes: > >> Bruce suggested to me off-list that when I commit a patch with > >> revisions, I ought to attach the committed patch to the email in which > >> I say that I have committed it. ?I know that Bruce habitually does > >> this, but I've never found it very helpful, since I prefer to look at > >> the patch either using the pgsql-committers emails or the git > >> respository. > > > > I quite agree --- people who want to read the committed patch are going > > to go to the source, not to what somebody claims he committed. > > Yeah, +1. I always go to one of the other sources (most of the time, > the gitweb or git server). > > It doesn't hurt to attach it if it happens to be around, but I > wouldn't suggest spending any extra effort on it... Well, many times I am applying a patch from an author that I have modified, and I don't expect them to be subscribed to committers, so I supply the patch as a courtesy so they can see my changes (and fix them). :-) -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Alvaro Herrera on 20 Apr 2010 13:11
Bruce Momjian escribi�: > Magnus Hagander wrote: > > Yeah, +1. I always go to one of the other sources (most of the time, > > the gitweb or git server). > > > > It doesn't hurt to attach it if it happens to be around, but I > > wouldn't suggest spending any extra effort on it... > > Well, many times I am applying a patch from an author that I have > modified, and I don't expect them to be subscribed to committers, so I > supply the patch as a courtesy so they can see my changes (and fix > them). :-) I think committing a patch from a non-regular is a special case and attaching the modified patch is reasonable in that case. My 8.8 Richter ... -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |