slub: Fix kmem_ptr_validate() for non-kernel pointers
in [Kernel]
|
Prev: slab: Generify kernel pointer validation
Next: ext4: BUG_ON could be triggered in ext4_mb_normalize_request()
From: Christoph Lameter on 7 Apr 2010 13:00 Acked-by: Christoph Lameter <cl(a)linux-foundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Rientjes on 8 Apr 2010 15:10
On Wed, 7 Apr 2010, Pekka Enberg wrote: > As suggested by Linus, fix up kmem_ptr_validate() to handle non-kernel pointers > more graciously. The patch changes kmem_ptr_validate() to use the newly > introduced kern_ptr_validate() helper to check that a pointer is a valid kernel > pointer before we attempt to convert it into a 'struct page'. > > Cc: Andrew Morton <akpm(a)linux-foundation.org> > Cc: Christoph Lameter <cl(a)linux-foundation.org> > Cc: David Rientjes <rientjes(a)google.com> Acked-by: David Rientjes <rientjes(a)google.com> > Cc: Ingo Molnar <mingo(a)elte.hu> > Cc: Matt Mackall <mpm(a)selenic.com> > Cc: Nick Piggin <npiggin(a)suse.de> > Signed-off-by: Pekka Enberg <penberg(a)cs.helsinki.fi> > --- > mm/slub.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index b364844..7d6c8b1 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2386,6 +2386,9 @@ int kmem_ptr_validate(struct kmem_cache *s, const void *object) > { > struct page *page; > > + if (!kern_ptr_validate(object, s->size)) > + return 0; > + > page = get_object_page(object); > > if (!page || s != page->slab) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |