Prev: [PATCH 6/7] IB/uverbs: pack struct ib_uverbs_event_file tighter
Next: hpfs: Convert sbi->hpfs_creation_de to mutex
From: Christoph Hellwig on 29 Jan 2010 17:20
On Fri, Jan 29, 2010 at 08:38:34PM -0000, Thomas Gleixner wrote:
> The semaphore server->sem is used as mutex. Rename it to server->mutex
> and convert it to a real mutex.
>
> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
> Cc: Al Viro <viro(a)zeniv.linux.org.uk>
> Cc: Jeff Layton <jlayton(a)redhat.com>
> Cc: Steve French <sfrench(a)us.ibm.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch(a)lst.de>

> static inline int
> smb_lock_server_interruptible(struct smb_sb_info *server)
> {
> - return down_interruptible(&(server->sem));
> + return mutex_lock_interruptible(&server->mutex);
> }
>
> static inline void
> smb_lock_server(struct smb_sb_info *server)
> {
> - down(&(server->sem));
> + mutex_lock(&server->mutex);
> }
>
> static inline void
> smb_unlock_server(struct smb_sb_info *server)
> {
> - up(&(server->sem));
> + mutex_unlock(&server->mutex);
> }

Eventually someone should also kill this useless wrappers, but let's do
one thing at a time for now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 6/7] IB/uverbs: pack struct ib_uverbs_event_file tighter
Next: hpfs: Convert sbi->hpfs_creation_de to mutex