smbget returns wrong exit code
in [Samba]
|
Prev: [Samba] Exceeding 200 client connections, no idle connection found in samba 3.4.4
Next: [Samba] Need connection log
From: Joerg Thuemmler on 8 Mar 2010 01:40 Jason Schaefer schrieb: > smbget -Rr smb://localhost/share > > [all files and folders are copied successfully!] > > echo $? > 1 > > On the other hand, when smbget is introduced with an error > > smbget -Rr smb://localhost/shar > Can't open directory smb://localhost/shar: No such file or directory > > echo $? > 0 > > This is breaking my error checking in backup scripts. I can't find any > place to file a bug report, I hope this is the right list > > Thanks > Jason Hi, found the same behavior using smbget with errornous parameters. Maybe it should do so: return not the error code but the count of files it got? Although that would be really strange... cu jth -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
From: Jason Schaefer on 8 Mar 2010 13:00 > found the same behavior using smbget with errornous parameters. Maybe it > should do so: return not the error code but the count of files it got? > Although that would be really strange... > > cu jth No, its just that the exit status is reversed from the standard. Successful completion should return 0 and unsuccessful should return 1. I see it as a bug. Exit status only has values of 0-255. So file count is out :-) -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
From: Jeremy Allison on 10 Mar 2010 18:20
On Mon, Mar 08, 2010 at 10:55:37AM -0700, Jason Schaefer wrote: > > found the same behavior using smbget with errornous parameters. Maybe it > > should do so: return not the error code but the count of files it got? > > Although that would be really strange... > > > > cu jth > > No, its just that the exit status is reversed from the standard. > Successful completion should return 0 and unsuccessful should return > 1. I see it as a bug. Exit status only has values of 0-255. So file > count is out :-) I think I've fixed this one recently (someone definitely logged a bug on this with a patch :-). Jeremy -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba |