splice fixes
in [Kernel]
|
Prev: [PATCH 3/3] splice: fix misuse of SPLICE_F_NONBLOCK
Next: avoid race condition in pick_next_task_fair in kernel/sched_fair.c
From: Jens Axboe on 29 Jun 2010 07:20 On 2010-06-29 13:08, Miklos Szeredi wrote: > These patches fix bugs that affect real-world users of splice(2) and > sendfile(2) interfaces. > > Not sure if some or all of them are appropriate for 2.6.35 and/or > -stable? I think that 1-2 should go into 2.6.35 directly, and 3 for .36 with a stable backport as well. Agree? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jens Axboe on 29 Jun 2010 08:10 On 2010-06-29 14:05, Miklos Szeredi wrote: > On Tue, 29 Jun 2010, Jens Axboe wrote: >> On 2010-06-29 13:08, Miklos Szeredi wrote: >>> These patches fix bugs that affect real-world users of splice(2) and >>> sendfile(2) interfaces. >>> >>> Not sure if some or all of them are appropriate for 2.6.35 and/or >>> -stable? >> >> I think that 1-2 should go into 2.6.35 directly, and 3 for .36 with >> a stable backport as well. Agree? > > Yes, sounds good. Good, that is what I queued up. I haven't pushed out the updated for-linus yet, since I asked Linus to pull it this morning. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Miklos Szeredi on 29 Jun 2010 08:10 On Tue, 29 Jun 2010, Jens Axboe wrote: > On 2010-06-29 13:08, Miklos Szeredi wrote: > > These patches fix bugs that affect real-world users of splice(2) and > > sendfile(2) interfaces. > > > > Not sure if some or all of them are appropriate for 2.6.35 and/or > > -stable? > > I think that 1-2 should go into 2.6.35 directly, and 3 for .36 with > a stable backport as well. Agree? Yes, sounds good. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 7 Jul 2010 16:50 On Tue, 29 Jun 2010 14:05:52 +0200 Jens Axboe <axboe(a)kernel.dk> wrote: > On 2010-06-29 14:05, Miklos Szeredi wrote: > > On Tue, 29 Jun 2010, Jens Axboe wrote: > >> On 2010-06-29 13:08, Miklos Szeredi wrote: > >>> These patches fix bugs that affect real-world users of splice(2) and > >>> sendfile(2) interfaces. > >>> > >>> Not sure if some or all of them are appropriate for 2.6.35 and/or > >>> -stable? > >> > >> I think that 1-2 should go into 2.6.35 directly, and 3 for .36 with > >> a stable backport as well. Agree? > > > > Yes, sounds good. > > Good, that is what I queued up. I haven't pushed out the updated > for-linus yet, since I asked Linus to pull it this morning. > According to Tim's report on lkml (http://lkml.org/lkml/2010/6/25/280), cc56f7de7f00d188c7c4da1e9861581853b9e92f caused a regression. cc56f7de7f00d188c7c4da1e9861581853b9e92f is present in 2.6.33 and in 2.6.34 hence the fix should be backported into -stable. According to http://bugs.launchpad.net/bugs/588861, the patch "splice: direct_splice_actor() should not use pos in sd" fixes the regression. However this: commit 4f9078afb4e083e033aafbbfabe729cb3832aa42 Author: Changli Gao <xiaosuo(a)gmail.com> Date: Tue Jun 29 13:09:18 2010 +0200 splice: direct_splice_actor() should not use pos in sd went into mainline without a cc:stable tag. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jens Axboe on 8 Jul 2010 09:40
On 2010-07-07 22:38, Andrew Morton wrote: > On Tue, 29 Jun 2010 14:05:52 +0200 > Jens Axboe <axboe(a)kernel.dk> wrote: > >> On 2010-06-29 14:05, Miklos Szeredi wrote: >>> On Tue, 29 Jun 2010, Jens Axboe wrote: >>>> On 2010-06-29 13:08, Miklos Szeredi wrote: >>>>> These patches fix bugs that affect real-world users of splice(2) and >>>>> sendfile(2) interfaces. >>>>> >>>>> Not sure if some or all of them are appropriate for 2.6.35 and/or >>>>> -stable? >>>> >>>> I think that 1-2 should go into 2.6.35 directly, and 3 for .36 with >>>> a stable backport as well. Agree? >>> >>> Yes, sounds good. >> >> Good, that is what I queued up. I haven't pushed out the updated >> for-linus yet, since I asked Linus to pull it this morning. >> > > According to Tim's report on lkml > (http://lkml.org/lkml/2010/6/25/280), > cc56f7de7f00d188c7c4da1e9861581853b9e92f caused a regression. > cc56f7de7f00d188c7c4da1e9861581853b9e92f is present in 2.6.33 and in > 2.6.34 hence the fix should be backported into -stable. > > According to http://bugs.launchpad.net/bugs/588861, the patch "splice: > direct_splice_actor() should not use pos in sd" fixes the regression. > > However this: > > commit 4f9078afb4e083e033aafbbfabe729cb3832aa42 > Author: Changli Gao <xiaosuo(a)gmail.com> > Date: Tue Jun 29 13:09:18 2010 +0200 > > splice: direct_splice_actor() should not use pos in sd > > went into mainline without a cc:stable tag. I will send an email to stable@. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |