Prev: [PATCH -mm 2/4] DMA-API.txt: remove dma_sync_single_range description
Next: DMA-API.txt: add dma_sync_single/sg API description
From: Wu Fengguang on 3 Feb 2010 22:20
From: Wu Fengguang <fengguang.wu(a)intel.com>

commit c85e9a97c4102ce2e83112da850d838cfab5ab13 upstream.

write_kmem() used to assume vwrite() always return the full buffer length.
However now vwrite() could return 0 to indicate memory hole. This creates
a bug that "buf" is not advanced accordingly.

Fix it to simply ignore the return value, hence the memory hole.

CC: Andi Kleen <andi(a)firstfloor.org>
CC: Benjamin Herrenschmidt <benh(a)kernel.crashing.org>
CC: Christoph Lameter <cl(a)linux-foundation.org>
CC: Ingo Molnar <mingo(a)elte.hu>
CC: Tejun Heo <tj(a)kernel.org>
CC: Nick Piggin <npiggin(a)suse.de>
CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com>
CC: <stable(a)kernel.org>
Signed-off-by: Wu Fengguang <fengguang.wu(a)intel.com>
---
drivers/char/mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.32.orig/drivers/char/mem.c 2010-02-04 10:37:55.000000000 +0800
+++ linux-2.6.32/drivers/char/mem.c 2010-02-04 10:37:59.000000000 +0800
@@ -599,7 +599,7 @@ static ssize_t write_kmem(struct file *
break;
}
}
- len = vwrite(kbuf, (char *)p, len);
+ vwrite(kbuf, (char *)p, len);
count -= len;
buf += len;
virtr += len;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH -mm 2/4] DMA-API.txt: remove dma_sync_single_range description
Next: DMA-API.txt: add dma_sync_single/sg API description