staging: comedi: formatting of pointers in printk()
in [Kernel]
|
Prev: [PATCH 09/16] x86, memblock: Add memblock_x86_free_memory_in_range()
Next: [PATCH 13/16] x86: Replace e820_/_early string with memblock_
From: Greg KH on 22 Jul 2010 14:50 On Thu, Jul 15, 2010 at 08:46:29AM +0200, Jiri Slaby wrote: > On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote: > > Use %p instead of %08x in printk(). > > > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> > > --- > > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c > > index 8d16380..8b49cb1 100644 > > --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c > > +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c > > @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len) > > The name and parameters suggest to remove the function completely. (And > use print_hex_dump_bytes instead.) I agree, Kulikov, can you make that chagne instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 22 Jul 2010 15:00
On Thu, 2010-07-22 at 11:45 -0700, Greg KH wrote: > On Thu, Jul 15, 2010 at 08:46:29AM +0200, Jiri Slaby wrote: > > On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote: > > The name and parameters suggest to remove the function completely. (And > > use print_hex_dump_bytes instead.) > I agree, Kulikov, can you make that chagne instead? The function isn't used at all and should simply be removed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |