staging: winbond: localpara.h whitespace and indentation fixes.
in [Kernel]
|
Prev: - Randomize node rotor used in cpuset_mem_spread_node()
Next: staging: winbond: mds.c whitspace, indentation etc.
From: Greg KH on 28 Apr 2010 19:10 On Fri, Mar 19, 2010 at 12:00:59AM +0100, Lars Lindley wrote: > On 2010-03-18 17:22, Pekka Enberg wrote: > > Lars Lindley wrote: > >> +/* refer Bitmap2RateValue table */ > >> +#define LOCAL_ALL_SUPPORTED_RATES_BITMAP 0x130c1a66 /* > >> + * the bitmap value > >> + * of all the H/W > >> + * supported rates: > >> + * 1, 2, 5.5, 11, > >> + * 6, 9, 12, 18, > >> + * 24, 36, 48, 54 > >> + */ > > > > The comments look funny. You might want to move them above the #defines. > > > >> + u8 region; /* real region setting of the device */ > >> + u8 Reserved_1[2]; > >> + > >> +/* power-save variables */ > > > > I think this wants to be moved one indentation level to the right. > > > Ok here's a patch that applies over the old one to fix this.. > Hope it looks all right.. :) Can you merge the two of them together and resend? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 3 May 2010 15:20
On Sun, May 02, 2010 at 10:34:08AM +0200, Lars Lindley wrote: > On 2010-04-29 00:50, Greg KH wrote: > > On Fri, Mar 19, 2010 at 12:00:59AM +0100, Lars Lindley wrote: > >> On 2010-03-18 17:22, Pekka Enberg wrote: > >>> Lars Lindley wrote: > >>>> +/* refer Bitmap2RateValue table */ > >>>> +#define LOCAL_ALL_SUPPORTED_RATES_BITMAP 0x130c1a66 /* > >>>> + * the bitmap value > >>>> + * of all the H/W > >>>> + * supported rates: > >>>> + * 1, 2, 5.5, 11, > >>>> + * 6, 9, 12, 18, > >>>> + * 24, 36, 48, 54 > >>>> + */ > >>> > >>> The comments look funny. You might want to move them above the #defines. > >>> > >>>> + u8 region; /* real region setting of the device */ > >>>> + u8 Reserved_1[2]; > >>>> + > >>>> +/* power-save variables */ > >>> > >>> I think this wants to be moved one indentation level to the right. > >>> > >> Ok here's a patch that applies over the old one to fix this.. > >> Hope it looks all right.. :) > > > > Can you merge the two of them together and resend? > > > > thanks, > > > > greg k-h > > > > I have somehow messed up my git tree so I can't get rebase to work but > here's the diff for localpara.h and that combines the two patches.. > Hope it works for you Greg. Yes it did, but it lacked a change log entry showing what the patch did, as well as a signed-off-by: line allowing me to apply the patch :( Care to resend it again with that required information? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |