staging: winbond: wb35reg_f.h Coding style fixes.
in [Kernel]
|
Prev: early_res: seperate common memmap func from e820.c to fw_memmap.c
Next: [PATCH 1/5] i2c-bfin-twi: integrate timeout timer with completion interface
From: Pekka Enberg on 22 Mar 2010 03:20 Lars Lindley kirjoitti: > I fixed the checkpatch things except a couple of long lines. > I also removed hungarian notation from the argument names > and some "commented away" code. > > Signed-off-by: Lars Lindley <lindley(a)coyote.org> Did you check that all these function declarations are actually used? I've spotted plenty of dead code in the past. > +/* > + * ==================================== > + * Interface function declare > + * ==================================== > + */ > +unsigned char Wb35Reg_initial(struct hw_data *HwData); Lets avoid CamelCase for the arguments so "hw_data" here, for example. I see the same thing elsewhere in this patch as well. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Lars Lindley on 22 Mar 2010 05:50 On 2010-03-22 08:16, Pekka Enberg wrote: > Lars Lindley kirjoitti: >> I fixed the checkpatch things except a couple of long lines. >> I also removed hungarian notation from the argument names >> and some "commented away" code. >> >> Signed-off-by: Lars Lindley <lindley(a)coyote.org> > > Did you check that all these function declarations are actually used? > I've spotted plenty of dead code in the past. > Nope, didn't check that. Just looking at the style now.. >> +/* >> + * ==================================== >> + * Interface function declare >> + * ==================================== >> + */ >> +unsigned char Wb35Reg_initial(struct hw_data *HwData); > > Lets avoid CamelCase for the arguments so "hw_data" here, for example. I > see the same thing elsewhere in this patch as well. > I thought struct hw_data *hw_data looked a bit confusing..Thats why I left CamelCase alone for now. I can make it like that if you want.. /Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 22 Mar 2010 06:00 On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley(a)coyote.org> wrote: > On 2010-03-22 08:16, Pekka Enberg wrote: >> Lars Lindley kirjoitti: >>> I fixed the checkpatch things except a couple of long lines. >>> I also removed hungarian notation from the argument names >>> and some "commented away" code. >>> >>> Signed-off-by: Lars Lindley <lindley(a)coyote.org> >> >> Did you check that all these function declarations are actually used? >> I've spotted plenty of dead code in the past. >> > Nope, didn't check that. Just looking at the style now.. Well, based on my experience, you're will do a lot of unnecessary work on code that's going to get removed because it's not actually used. That's why I haven't bothered with style cleanups much. >>> +/* >>> + * ==================================== >>> + * Interface function declare >>> + * ==================================== >>> + */ >>> +unsigned char Wb35Reg_initial(struct hw_data *HwData); >> >> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I >> see the same thing elsewhere in this patch as well. >> > I thought struct hw_data *hw_data looked a bit confusing..Thats why I left > CamelCase alone for now. I can make it like that if you want.. Yes please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 22 Mar 2010 07:00 On Mon, Mar 22, 2010 at 12:55 PM, Lars Lindley <lindley(a)coyote.org> wrote: > Here's a new patch against master that fixes CamelCase too. > > [PATCH] staging: winbond: wb35reg_f.h Coding style fixes. > > I fixed the checkpatch things except a couple of long lines. > I also removed hungarian notation and CamelCase from the argument names > and some "commented away" code. > > Signed-off-by: Lars Lindley <lindley(a)coyote.org> Acked-by: Pekka Enberg <penberg(a)cs.helsinki.fi> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on 22 Mar 2010 07:00
> On 2010-03-22 10:57, Pekka Enberg wrote: > > On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley(a)coyote.org> wrote: > >> On 2010-03-22 08:16, Pekka Enberg wrote: > >>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData); > >>> > >>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I > >>> see the same thing elsewhere in this patch as well. > >>> > >> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left > >> CamelCase alone for now. I can make it like that if you want.. > > > > Yes please. > > > > > Here's a new patch against master that fixes CamelCase too. > > > > [PATCH] staging: winbond: wb35reg_f.h Coding style fixes. > > I fixed the checkpatch things except a couple of long lines. > I also removed hungarian notation and CamelCase from the argument names > and some "commented away" code. > > Signed-off-by: Lars Lindley <lindley(a)coyote.org> ACK. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |