superfluous copydir() prototype in pg_upgrade.h
in [PgSql]
|
Prev: [HACKERS] superfluous copydir() prototype in pg_upgrade.h
Next: [HACKERS] reassign owned to change the ownership for op class and family
From: Tom Lane on 1 Jul 2010 10:35 Robert Haas <robertmhaas(a)gmail.com> writes: > While looking at Guillaume Lelarge's patch to add > CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to > have a $SUBJECT. > Trivial patch attached. The rmtree() declaration below it shouldn't be there either ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Bruce Momjian on 1 Jul 2010 10:37
Tom Lane wrote: > Robert Haas <robertmhaas(a)gmail.com> writes: > > While looking at Guillaume Lelarge's patch to add > > CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to > > have a $SUBJECT. > > > Trivial patch attached. > > The rmtree() declaration below it shouldn't be there either ... When pg_upgrade was not in /contrib, I was concerned about including port.h, but at this point, I think it is fine. Both removed. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + None of us is going to be here forever. + -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |