From: Fujii Masao on
On Wed, Jul 14, 2010 at 11:59 PM, Robert Haas <robertmhaas(a)gmail.com> wrote:
> On Wed, Jul 14, 2010 at 3:41 AM, Fujii Masao <masao.fujii(a)gmail.com> wrote:
>> I read the patch and found some small typos.
>
> Thanks. �Corrected version attached.
>
>> We should add something like?:
>>
>> ---------
>> Even if this value is set to true, a backend crash during hot standby doesn't
>> reinitialize the database.
>> ---------
>
> Is that actually true? AFAICS, RecoveryError only gets set if the
> *startup* process crashes.

Oh, true. Sorry for noise.

I changed the status of the patch to "ready for committer".

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Simon Riggs on
On Sun, 2010-06-27 at 20:54 -0400, Robert Haas wrote:
> automatic_restart = true # reinitialize after backend crash?

"automatic_restart" makes me think "when does that happen?".

Can we call this "restart_after_crash"? Or similar. So we are explicit
about when the restart will kick in.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Training and Services


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on
Simon Riggs <simon(a)2ndQuadrant.com> writes:
> On Sun, 2010-06-27 at 20:54 -0400, Robert Haas wrote:
>> automatic_restart = true # reinitialize after backend crash?

> "automatic_restart" makes me think "when does that happen?".

> Can we call this "restart_after_crash"? Or similar.

+1. "automatic_restart" is close to content-free.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Sat, Jul 17, 2010 at 10:16 AM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote:
> Simon Riggs <simon(a)2ndQuadrant.com> writes:
>> On Sun, 2010-06-27 at 20:54 -0400, Robert Haas wrote:
>>> automatic_restart = true � � �# reinitialize after backend crash?
>
>> "automatic_restart" makes me think "when does that happen?".
>
>> Can we call this "restart_after_crash"? Or similar.
>
> +1. �"automatic_restart" is close to content-free.

OK, committed that way.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers