sync_mm_rss() issues
in [Kernel]
|
Prev: Linux-2.6.33 to 33-git9 intel_drm: drm_fb_helper panic
Next: Adding Support for SPEAr Platform under ARM architecture
From: David Howells on 8 Mar 2010 09:10 There are a couple of issues with sync_mm_rss(), as added by patch: commit 34e55232e59f7b19050267a05ff1226e5cd122a5 Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> Date: Fri Mar 5 13:41:40 2010 -0800 Subject: mm: avoid false sharing of mm_counter (1) You haven't implemented it for NOMMU mode. What's the right way to do this? Just give an empty function? (2) linux/mm.h should carry the empty function as an inline when CONFIG_SPLIT_RSS_COUNTING=n, rather than it being defined as an empty function in mm/memory.c. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: KAMEZAWA Hiroyuki on 8 Mar 2010 19:00
On Mon, 08 Mar 2010 13:59:56 +0000 David Howells <dhowells(a)redhat.com> wrote: > > There are a couple of issues with sync_mm_rss(), as added by patch: > > commit 34e55232e59f7b19050267a05ff1226e5cd122a5 > Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> > Date: Fri Mar 5 13:41:40 2010 -0800 > Subject: mm: avoid false sharing of mm_counter > > (1) You haven't implemented it for NOMMU mode. What's the right way to do > this? Just give an empty function? > Ah, sorry. I'll prepare empty function immediately. But I have no NOMMU enviroment... > (2) linux/mm.h should carry the empty function as an inline when > CONFIG_SPLIT_RSS_COUNTING=n, rather than it being defined as an empty > function in mm/memory.c. > ok. please wait.. Sorry, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |