sysctl extern cleanup - binfmts
in [Kernel]
|
Prev: [PATCH -mm 08/17] sysctl extern cleanup - file nr
Next: [PATCH -mm 02/17] sysctl extern cleanup - signal
From: Alexey Dobriyan on 21 Feb 2010 09:30 On Sun, Feb 21, 2010 at 10:23:03PM +0800, Dave Young wrote: > --- linux-2.6.32.orig/include/linux/binfmts.h > +++ linux-2.6.32/include/linux/binfmts.h > @@ -20,6 +20,11 @@ struct pt_regs; > #ifdef __KERNEL__ > #include <linux/list.h> > > +/* for sysctl */ This comment is neither accurate nor needed. :^) In fact master sysctl table always was a big mess, so slight mess caused by extern declarations is fine. > +extern int core_uses_pid; > +extern char *core_pattern; > +extern unsigned int core_pipe_limit; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alexey Dobriyan on 21 Feb 2010 09:40 On Sun, Feb 21, 2010 at 10:33:43PM +0800, Dave Young wrote: > On Sun, Feb 21, 2010 at 10:28 PM, Alexey Dobriyan <adobriyan(a)gmail.com> wrote: > > On Sun, Feb 21, 2010 at 10:23:03PM +0800, Dave Young wrote: > >> --- linux-2.6.32.orig/include/linux/binfmts.h > >> +++ linux-2.6.32/include/linux/binfmts.h > >> @@ -20,6 +20,11 @@ struct pt_regs; > >> �#ifdef __KERNEL__ > >> �#include <linux/list.h> > >> > >> +/* for sysctl */ > > > > This comment is neither accurate nor needed. :^) > > Thanks, sounds good, but the there's no other file use the three vars. > > > > > In fact master sysctl table always was a big mess, so slight mess > > caused by extern declarations is fine. > > > >> +extern int core_uses_pid; > >> +extern char *core_pattern; > >> +extern unsigned int core_pipe_limit; In fact coredump code should be moved out of fs/exec.c including headers, so this movement is quite pointless. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dave Young on 21 Feb 2010 09:50
On Sun, Feb 21, 2010 at 10:28 PM, Alexey Dobriyan <adobriyan(a)gmail.com> wrote: > On Sun, Feb 21, 2010 at 10:23:03PM +0800, Dave Young wrote: >> --- linux-2.6.32.orig/include/linux/binfmts.h >> +++ linux-2.6.32/include/linux/binfmts.h >> @@ -20,6 +20,11 @@ struct pt_regs; >> #ifdef __KERNEL__ >> #include <linux/list.h> >> >> +/* for sysctl */ > > This comment is neither accurate nor needed. :^) Thanks, sounds good, but the there's no other file use the three vars. > > In fact master sysctl table always was a big mess, so slight mess > caused by extern declarations is fine. > >> +extern int core_uses_pid; >> +extern char *core_pattern; >> +extern unsigned int core_pipe_limit; > -- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |