Prev: [PATCH] thinkpad-acpi: fix return value of volume callbacks
Next: [net-next PATCH v6 0/3] net: reserve ports for applications using fixed port numbers
From: Linus Torvalds on 26 Feb 2010 20:10


On Fri, 26 Feb 2010, Rafał Miłecki wrote:
>
> Following macro is soemthing that seems to work fine for us, but instead
> introducing this to radeon KMS only, I'd like to propose adding this to whole
> wait.h. Do you this it's something we should place there? Can someone take this
> patch for me? Or maybe you find this rather useless and we should keep this
> marco locally?

This does not smell generic to me. In fact, it makes me personally think
you're doing something wrong in the first place, but maybe it's ok. But in
case it really is ok, I'd still not put it in a generic header file unless
you can point to other cases where it really makes sense to do this.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] thinkpad-acpi: fix return value of volume callbacks
Next: [net-next PATCH v6 0/3] net: reserve ports for applications using fixed port numbers