[tip:irq/core] xen: Do not suspend IPI IRQs.
in [Kernel]
|
Prev: [tip:irq/core] ixp4xx-beeper: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupt
Next: [tip:irq/core] powerpc: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupts
From: tip-bot for Ian Campbell on 29 Jul 2010 07:40 Commit-ID: 4877c737283813bdb4bebfa3168c1585f6e3a8ca Gitweb: http://git.kernel.org/tip/4877c737283813bdb4bebfa3168c1585f6e3a8ca Author: Ian Campbell <ian.campbell(a)citrix.com> AuthorDate: Thu, 29 Jul 2010 11:16:35 +0100 Committer: Thomas Gleixner <tglx(a)linutronix.de> CommitDate: Thu, 29 Jul 2010 13:24:58 +0200 xen: Do not suspend IPI IRQs. In general the semantics of IPIs are that they are are expected to continue functioning after dpm_suspend_noirq(). Specifically I have seen a deadlock between the callfunc IPI and the stop machine used by xen's do_suspend() routine. If one CPU has already called dpm_suspend_noirq() then there is a window where it can be sent a callfunc IPI before all the other CPUs have entered stop_cpu(). If this happens then the first CPU ends up spinning in stop_cpu() waiting for the other to rendezvous in state STOPMACHINE_PREPARE while the other is spinning in csd_lock_wait(). Signed-off-by: Ian Campbell <ian.campbell(a)citrix.com> Cc: Jeremy Fitzhardinge <jeremy(a)goop.org> Cc: xen-devel(a)lists.xensource.com LKML-Reference: <1280398595-29708-4-git-send-email-ian.campbell(a)citrix.com> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> --- drivers/xen/events.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index db8f506..28f133a 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -536,6 +536,7 @@ int bind_ipi_to_irqhandler(enum ipi_vector ipi, if (irq < 0) return irq; + irqflags |= IRQF_NO_SUSPEND; retval = request_irq(irq, handler, irqflags, devname, dev_id); if (retval != 0) { unbind_from_irq(irq); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |