[tip:perf/core] perf: Fix hist_entry__tui_annotate() build failure
in [Kernel]
|
Prev: [RFC v2] ext4: Don't send extra barrier during fsync if there are no dirty pages.
Next: 2.6.34 Northbridge Chipset Errors on HP Proliant 4 x Opteron in x86_64 mode
From: tip-bot for Srikar Dronamraju on 29 Jun 2010 17:10 Commit-ID: 0879b100f3c187257729f36cba33d96ec2875766 Gitweb: http://git.kernel.org/tip/0879b100f3c187257729f36cba33d96ec2875766 Author: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com> AuthorDate: Tue, 29 Jun 2010 23:02:26 +0530 Committer: Ingo Molnar <mingo(a)elte.hu> CommitDate: Tue, 29 Jun 2010 22:59:05 +0200 perf: Fix hist_entry__tui_annotate() build failure When compiling perf on latest tip/master I see the following error: cc1: warnings being treated as errors util/newt.c: In function 'hist_entry__tui_annotate': util/newt.c:764: warning: 'ret' is used uninitialized in this function make: *** [util/newt.o] Error 1 I think the problem was introduced by commit 13f499f076c67675e6e3022973729b5d906a84e9 Below is a patch that fixes the problem. Signed-off-by: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com> Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com> LKML-Reference: <20100629173226.GC23231(a)linux.vnet.ibm.com> Signed-off-by: Ingo Molnar <mingo(a)elte.hu> --- tools/perf/util/newt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c index 89c52fc..06f248f 100644 --- a/tools/perf/util/newt.c +++ b/tools/perf/util/newt.c @@ -753,7 +753,7 @@ int hist_entry__tui_annotate(struct hist_entry *self) browser.width += 18; /* Percentage */ ui_browser__show(&browser, self->ms.sym->name); - ui_browser__run(&browser, &es); + ret = ui_browser__run(&browser, &es); newtFormDestroy(browser.form); newtPopWindow(); list_for_each_entry_safe(pos, n, &head, node) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |