Prev: Fix a race in pid generation that causes pids to be reused immediately.
Next: FRV: Implement the GDB remote protocol 'p' command to retrieve a register
From: tip-bot for Oleg Nesterov on 9 Jun 2010 14:20
Commit-ID: 018378c55b03f88ff513aba4e0e93b8d4a9cf241
Gitweb: http://git.kernel.org/tip/018378c55b03f88ff513aba4e0e93b8d4a9cf241
Author: Oleg Nesterov <oleg(a)redhat.com>
AuthorDate: Thu, 3 Jun 2010 21:32:43 +0200
Committer: Frederic Weisbecker <fweisbec(a)gmail.com>
CommitDate: Wed, 9 Jun 2010 17:32:19 +0200

x86: Unify save_stack_address() and save_stack_address_nosched()

Cleanup. Factor the common code in save_stack_address() and
save_stack_address_nosched().

Signed-off-by: Oleg Nesterov <oleg(a)redhat.com>
Cc: Roland McGrath <roland(a)redhat.com>
Cc: Arjan van de Ven <arjan(a)linux.intel.com>
Cc: Vegard Nossum <vegard.nossum(a)gmail.com>
Cc: Ingo Molnar <mingo(a)elte.hu>
LKML-Reference: <20100603193243.GA31534(a)redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com>
---
arch/x86/kernel/stacktrace.c | 24 ++++++++++--------------
1 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/arch/x86/kernel/stacktrace.c b/arch/x86/kernel/stacktrace.c
index abc321d..b53c525 100644
--- a/arch/x86/kernel/stacktrace.c
+++ b/arch/x86/kernel/stacktrace.c
@@ -23,13 +23,16 @@ static int save_stack_stack(void *data, char *name)
return 0;
}

-static void save_stack_address(void *data, unsigned long addr, int reliable)
+static void
+__save_stack_address(void *data, unsigned long addr, bool reliable, bool nosched)
{
struct stack_trace *trace = data;
#ifdef CONFIG_FRAME_POINTER
if (!reliable)
return;
#endif
+ if (nosched && in_sched_functions(addr))
+ return;
if (trace->skip > 0) {
trace->skip--;
return;
@@ -38,22 +41,15 @@ static void save_stack_address(void *data, unsigned long addr, int reliable)
trace->entries[trace->nr_entries++] = addr;
}

+static void save_stack_address(void *data, unsigned long addr, int reliable)
+{
+ return __save_stack_address(data, addr, reliable, false);
+}
+
static void
save_stack_address_nosched(void *data, unsigned long addr, int reliable)
{
- struct stack_trace *trace = data;
-#ifdef CONFIG_FRAME_POINTER
- if (!reliable)
- return;
-#endif
- if (in_sched_functions(addr))
- return;
- if (trace->skip > 0) {
- trace->skip--;
- return;
- }
- if (trace->nr_entries < trace->max_entries)
- trace->entries[trace->nr_entries++] = addr;
+ return __save_stack_address(data, addr, reliable, true);
}

static const struct stacktrace_ops save_stack_ops = {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Fix a race in pid generation that causes pids to be reused immediately.
Next: FRV: Implement the GDB remote protocol 'p' command to retrieve a register