[tip:perf/urgent] perf-record: Check correct pid when forking
in [Kernel]
|
Prev: linux-next: build failure after merge of the hwpoison tree
Next: [2.6.35-rc1 BUG]: Calling sched_clock causes stack trace with DEBUG_PREEMPT
From: tip-bot for Borislav Petkov on 1 Jun 2010 03:10 Commit-ID: 2fb750e825b5347de0390315f4284f13709a9856 Gitweb: http://git.kernel.org/tip/2fb750e825b5347de0390315f4284f13709a9856 Author: Borislav Petkov <bp(a)alien8.de> AuthorDate: Mon, 31 May 2010 23:18:18 +0200 Committer: Frederic Weisbecker <fweisbec(a)gmail.com> CommitDate: Tue, 1 Jun 2010 00:57:14 +0200 perf-record: Check correct pid when forking When forking the child to be traced, we should check the correct return value from fork() and not a local variable which is otherwise unused. Signed-off-by: Borislav Petkov <bp(a)alien8.de> Cc: Ingo Molnar <mingo(a)elte.hu> Cc: Peter Zijlstra <a.p.zijlstra(a)chello.nl> Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com> Cc: Paul Mackerras <paulus(a)samba.org> Cc: Tom Zanussi <tzanussi(a)gmail.com> Cc: Stephane Eranian <eranian(a)google.com> LKML-Reference: <20100531211818.GA30175(a)liondog.tnic> Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com> --- tools/perf/builtin-record.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 9bc8905..dc3435e 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -503,7 +503,6 @@ static int __cmd_record(int argc, const char **argv) { int i, counter; struct stat st; - pid_t pid = 0; int flags; int err; unsigned long waking = 0; @@ -572,7 +571,7 @@ static int __cmd_record(int argc, const char **argv) if (forks) { child_pid = fork(); - if (pid < 0) { + if (child_pid < 0) { perror("failed to fork"); exit(-1); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |