[tip:perf/urgent] perf tools: Fix find tids routine by excluding "." and ".."
in [Kernel]
|
Prev: [tip:perf/urgent] perf, x86: Fix incorrect branches event on AMD CPUs
Next: [PATCH/RFC v3] hwmon: Add support for W83667HG-B to w83627ehf driver.
From: tip-bot for Gui Jianfeng on 3 Jul 2010 10:00 Commit-ID: c214909b36efec632432acdcbfacdd46a6e11370 Gitweb: http://git.kernel.org/tip/c214909b36efec632432acdcbfacdd46a6e11370 Author: Gui Jianfeng <guijianfeng(a)cn.fujitsu.com> AuthorDate: Wed, 16 Jun 2010 13:21:44 +0800 Committer: Arnaldo Carvalho de Melo <acme(a)redhat.com> CommitDate: Thu, 1 Jul 2010 14:02:38 -0300 perf tools: Fix find tids routine by excluding "." and ".." Introduce a filter function to skip "." and ".." directories when calculating tid number, otherwise tid 0 will be included in the all_tid result array. Cc: Ingo Molnar <mingo(a)elte.hu> LKML-Reference: <4C185F68.1020505(a)cn.fujitsu.com> Signed-off-by: Gui Jianfeng <guijianfeng(a)cn.fujitsu.com> Signed-off-by: Arnaldo Carvalho de Melo <acme(a)redhat.com> --- tools/perf/util/thread.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c index 1f7ecd4..9a448b4 100644 --- a/tools/perf/util/thread.c +++ b/tools/perf/util/thread.c @@ -7,6 +7,15 @@ #include "util.h" #include "debug.h" +/* Skip "." and ".." directories */ +static int filter(const struct dirent *dir) +{ + if (dir->d_name[0] == '.') + return 0; + else + return 1; +} + int find_all_tid(int pid, pid_t ** all_tid) { char name[256]; @@ -16,7 +25,7 @@ int find_all_tid(int pid, pid_t ** all_tid) int i; sprintf(name, "/proc/%d/task", pid); - items = scandir(name, &namelist, NULL, NULL); + items = scandir(name, &namelist, filter, NULL); if (items <= 0) return -ENOENT; *all_tid = malloc(sizeof(pid_t) * items); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |