[tip:x86/atomic] lib: Fix atomic64_inc_not_zero test
in [Kernel]
|
Prev: [tip:x86/atomic] x86, atomic64: In selftest, distinguish x86-64 from 586+
Next: [tip:x86/atomic] lib: Only test atomic64_dec_if_positive on archs having it
From: tip-bot for Luca Barbieri on 1 Mar 2010 15:00 Commit-ID: 25a304f277ad70166eeae25a4958d2049005c33a Gitweb: http://git.kernel.org/tip/25a304f277ad70166eeae25a4958d2049005c33a Author: Luca Barbieri <luca(a)luca-barbieri.com> AuthorDate: Mon, 1 Mar 2010 19:55:48 +0100 Committer: H. Peter Anvin <hpa(a)zytor.com> CommitDate: Mon, 1 Mar 2010 11:39:02 -0800 lib: Fix atomic64_inc_not_zero test atomic64_inc_not_zero must return 1 if it perfomed the add and 0 otherwise. The test assumed the opposite convention. Signed-off-by: Luca Barbieri <luca(a)luca-barbieri.com> LKML-Reference: <1267469749-11878-5-git-send-email-luca(a)luca-barbieri.com> Signed-off-by: H. Peter Anvin <hpa(a)zytor.com> --- lib/atomic64_test.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c index ee8e6de..f7bb706 100644 --- a/lib/atomic64_test.c +++ b/lib/atomic64_test.c @@ -130,16 +130,16 @@ static __init int test_atomic64(void) #endif INIT(onestwos); - BUG_ON(atomic64_inc_not_zero(&v)); + BUG_ON(!atomic64_inc_not_zero(&v)); r += one; BUG_ON(v.counter != r); INIT(0); - BUG_ON(!atomic64_inc_not_zero(&v)); + BUG_ON(atomic64_inc_not_zero(&v)); BUG_ON(v.counter != r); INIT(-one); - BUG_ON(atomic64_inc_not_zero(&v)); + BUG_ON(!atomic64_inc_not_zero(&v)); r += one; BUG_ON(v.counter != r); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |