[tip:x86/olpc] x86, olpc: Use pr_debug() for EC commands
in [Kernel]
|
Prev: [patch v2 1/2] workqueue: mark init_workqueues() as early_initcall()
Next: [tip:x86/olpc] x86, olpc: Constify an olpc_ofw() arg
From: tip-bot for Andres Salomon on 30 Jul 2010 21:20 Commit-ID: 25971865d48a8d0ece5307a59dbd3f06d05a7567 Gitweb: http://git.kernel.org/tip/25971865d48a8d0ece5307a59dbd3f06d05a7567 Author: Andres Salomon <dilinger(a)queued.net> AuthorDate: Wed, 16 Jun 2010 23:19:28 -0400 Committer: H. Peter Anvin <hpa(a)linux.intel.com> CommitDate: Fri, 30 Jul 2010 18:01:52 -0700 x86, olpc: Use pr_debug() for EC commands Unconditionally printing EC debug messages was helpful when we were actually debugging the EC, but during normal operation it can get pretty annoying. Using pr_debug allows us finer-grained control. Signed-off-by: Andres Salomon <dilinger(a)queued.net> LKML-Reference: <20100616231928.16b539f0(a)dev.queued.net> Signed-off-by: H. Peter Anvin <hpa(a)linux.intel.com> --- arch/x86/kernel/olpc.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/olpc.c b/arch/x86/kernel/olpc.c index 1566052..f5ff3903 100644 --- a/arch/x86/kernel/olpc.c +++ b/arch/x86/kernel/olpc.c @@ -142,7 +142,7 @@ restart: * The OBF flag will sometimes misbehave due to what we believe * is a hardware quirk.. */ - printk(KERN_DEBUG "olpc-ec: running cmd 0x%x\n", cmd); + pr_devel("olpc-ec: running cmd 0x%x\n", cmd); outb(cmd, 0x6c); if (wait_on_ibf(0x6c, 0)) { @@ -159,8 +159,7 @@ restart: " EC accept data!\n"); goto err; } - printk(KERN_DEBUG "olpc-ec: sending cmd arg 0x%x\n", - inbuf[i]); + pr_devel("olpc-ec: sending cmd arg 0x%x\n", inbuf[i]); outb(inbuf[i], 0x68); } } @@ -173,8 +172,7 @@ restart: goto restart; } outbuf[i] = inb(0x68); - printk(KERN_DEBUG "olpc-ec: received 0x%x\n", - outbuf[i]); + pr_devel("olpc-ec: received 0x%x\n", outbuf[i]); } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |