[tip:x86/uv] x86, UV: Correct BAU regular message type
in [Kernel]
|
Prev: [tip:perf/core] perf, x86: Small fix to cpuid10_edx
Next: [tip:perf/core] perf: Fix signed comparison in perf_adjust_period()
From: tip-bot for Cliff Wickman on 8 Jun 2010 17:00 Commit-ID: 7fba1bcd4844a4a8619a03bf51cabc92aea365a8 Gitweb: http://git.kernel.org/tip/7fba1bcd4844a4a8619a03bf51cabc92aea365a8 Author: Cliff Wickman <cpw(a)sgi.com> AuthorDate: Wed, 2 Jun 2010 16:22:02 -0500 Committer: Ingo Molnar <mingo(a)elte.hu> CommitDate: Tue, 8 Jun 2010 21:13:47 +0200 x86, UV: Correct BAU regular message type The Broadcast Assist Unit messages have a regular or retry message type. The regular type was not being set, but needs to be, because the lack of a message type is sometimes used to identify an unused entry in the message queue. Also removing some excess comments. Signed-off-by: Cliff Wickman <cpw(a)sgi.com> Cc: gregkh(a)suse.de LKML-Reference: <E1OJvNy-0004ak-Dy(a)eag09.americas.sgi.com> Signed-off-by: Ingo Molnar <mingo(a)elte.hu> --- arch/x86/kernel/tlb_uv.c | 15 +-------------- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/arch/x86/kernel/tlb_uv.c b/arch/x86/kernel/tlb_uv.c index dc962b5..4cb14db 100644 --- a/arch/x86/kernel/tlb_uv.c +++ b/arch/x86/kernel/tlb_uv.c @@ -580,23 +580,10 @@ const struct cpumask *uv_flush_send_and_wait(struct bau_desc *bau_desc, } time1 = get_cycles(); do { - /* - * Every message from any given cpu gets a unique message - * sequence number. But retries use that same number. - * Our message may have timed out at the destination because - * all sw-ack resources are in use and there is a timeout - * pending there. In that case, our last send never got - * placed into the queue and we need to persist until it - * does. - * - * Make any retry a type MSG_RETRY so that the destination will - * free any resource held by a previous message from this cpu. - */ if (try == 0) { - /* use message type set by the caller the first time */ + bau_desc->header.msg_type = MSG_REGULAR; seq_number = bcp->message_number++; } else { - /* use RETRY type on all the rest; same sequence */ bau_desc->header.msg_type = MSG_RETRY; stat->s_retry_messages++; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |