touchscreen: fix sign bug
in [Kernel]
|
Prev: xstat: Add a pair of system calls to make extended file stats available [ver #6]
Next: char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: Luotao Fu on 15 Jul 2010 16:50 On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote: > platform_get_irq_byname() can return negative results, it is not seen to > unsigned ts_irq. Make it signed. > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> Acked-By: Luotao Fu <l.fu(a)pengutronix.de> > --- > drivers/input/touchscreen/stmpe-ts.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c > index 77f4374..656148e 100644 > --- a/drivers/input/touchscreen/stmpe-ts.c > +++ b/drivers/input/touchscreen/stmpe-ts.c > @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev) > struct input_dev *idev; > struct stmpe_ts_platform_data *ts_pdata = NULL; > int ret = 0; > - unsigned int ts_irq; > + int ts_irq; > > ts_irq = platform_get_irq_byname(pdev, "FIFO_TH"); > if (ts_irq < 0) > -- > 1.7.0.4 > Stupid bug. Thanks for catching this. cheers Luotao Fu -- Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
From: Dmitry Torokhov on 16 Jul 2010 03:20 On Thu, Jul 15, 2010 at 10:49:27PM +0200, Luotao Fu wrote: > On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote: > > platform_get_irq_byname() can return negative results, it is not seen to > > unsigned ts_irq. Make it signed. > > > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> > > Acked-By: Luotao Fu <l.fu(a)pengutronix.de> > OK, the driver is still in Samuel's tree so he gets to pick the patch... Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 25 Jul 2010 17:40
Hi Vasiliy, On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote: > platform_get_irq_byname() can return negative results, it is not seen to > unsigned ts_irq. Make it signed. Patch applied to my mfd tree, thanks. Cheers, Samuel. > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> > --- > drivers/input/touchscreen/stmpe-ts.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c > index 77f4374..656148e 100644 > --- a/drivers/input/touchscreen/stmpe-ts.c > +++ b/drivers/input/touchscreen/stmpe-ts.c > @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev) > struct input_dev *idev; > struct stmpe_ts_platform_data *ts_pdata = NULL; > int ret = 0; > - unsigned int ts_irq; > + int ts_irq; > > ts_irq = platform_get_irq_byname(pdev, "FIFO_TH"); > if (ts_irq < 0) > -- > 1.7.0.4 > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |