Prev: linux-next: build failure after merge of the viafb tree
Next: [GIT PULL] XFS update for 2.6.35-rc1 (2 of 2)
From: Steven Rostedt on 24 May 2010 23:10 On Tue, 2010-05-18 at 22:30 +0530, Srikar Dronamraju wrote: > This is based on trace_events for kprobes to the extent that it may > resemble that file on 2.6.34. Check the changes that have been done in tip/perf/core. These will be going mainline for 35. The interface with the ftrace_event_call structure will affect this patch too. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Srikar Dronamraju on 25 May 2010 08:30 * Steven Rostedt <rostedt(a)goodmis.org> [2010-05-24 22:22:10]: > On Tue, 2010-05-18 at 22:30 +0530, Srikar Dronamraju wrote: > > > This is based on trace_events for kprobes to the extent that it may > > resemble that file on 2.6.34. > > Check the changes that have been done in tip/perf/core. These will be > going mainline for 35. The interface with the ftrace_event_call > structure will affect this patch too. > Okay, I shall update the trace_events for uprobes to the current changes in tip/master. -- Thanks and Regards Srikar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Steven Rostedt on 21 Jun 2010 10:30 On Mon, 2010-06-14 at 14:00 +0530, Srikar Dronamraju wrote: > +config UPROBE_EVENT > + depends on UPROBES > + bool "Enable uprobes-based dynamic events" > + select TRACING > + default y Why is this default y? -- Steve > + help > + This allows the user to add tracing events on top of userspace dynamic > + events (similar to tracepoints) on the fly via the traceevents interface. > + Those events can be inserted wherever uprobes can probe, and record > + various registers. > + This option is required if you plan to use perf-probe subcommand of perf > + tools on user space applications. > + > endif # FTRACE > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Srikar Dronamraju on 22 Jun 2010 00:20 > > > +config UPROBE_EVENT > > + depends on UPROBES > > + bool "Enable uprobes-based dynamic events" > > + select TRACING > > + default y > > Why is this default y? As you see UPROBE_EVENT is gated on UPROBES. I think if UPROBES is enabled, then UPROBE_EVENT should be enabled. Esp with Christoph suggesting for module support to be removed, I think it becomes all the more reason for UPROBE_EVENT to be enabled by default. Otherwise there is no point in having uprobes code and having no enabled users. I was even looking at "select UPROBE_EVENT" on enabling UPROBES. Do you have any specific reason why UPROBE_EVENT should not be enabled by default? -- Thanks and Regards Srikar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on 22 Jun 2010 02:40
On Tue, Jun 22, 2010 at 09:45:29AM +0530, Srikar Dronamraju wrote: > As you see UPROBE_EVENT is gated on UPROBES. I think if UPROBES is > enabled, then UPROBE_EVENT should be enabled. Esp with Christoph > suggesting for module support to be removed, I think it becomes all the > more reason for UPROBE_EVENT to be enabled by default. Otherwise there > is no point in having uprobes code and having no enabled users. > I was even looking at "select UPROBE_EVENT" on enabling UPROBES. > > Do you have any specific reason why UPROBE_EVENT should not be enabled > by default? default y generally is a big hammer. But given that it depends on UPROBES it might be fine here. Then again the big question is why we even bother with separate config options? At least in this form UPROBES just is supported for UPROBE_EVENT. So it makes sense either to remove the UPROBES option entirely, or at least make it invisible to the user and let UPROBE_EVENT select it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |