Prev: X86: intel_ips, check for kzalloc properly
Next: [PATCH] X86: intel_ips, check for kzalloc properly
From: Mathieu Desnoyers on 21 Jun 2010 11:50
* Steven Rostedt (rostedt(a)goodmis.org) wrote:
> On Mon, 2010-06-21 at 19:09 +0800, Wu Zhangjin wrote:
> > From: Wu Zhangjin <wuzhangjin(a)gmail.com>
> >
> > The header file include/linux/tracepoint.h may be included without
> > include/linux/errno.h and then the compiler will fail on building for
> > undelcared ENOSYS. This patch fixes this problem via including <linux/errno.h>
> > to include/linux/tracepoint.h.
> >
>
> Hi Wu,
>
> I have not hit this. Did you hit this with mips? Does it need to get
> into 2.6.35 or can it wait till 2.6.36?

errno.h is included by sched.h, which is included almost everywhere. No
wonder it took that much time for someone to hit the problem. But given
it's a simple bug fix, it should fit into the "for-2.6.35" definition,
although I am no expert in these definitions. ;-)

Thanks,

Mathieu

>
> -- Steve
>
> > Signed-off-by: Wu Zhangjin <wuzhangjin(a)gmail.com>
> > ---
> > include/linux/tracepoint.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> > index 9a59d1f..103d1b6 100644
> > --- a/include/linux/tracepoint.h
> > +++ b/include/linux/tracepoint.h
> > @@ -14,6 +14,7 @@
> > * See the file COPYING for more details.
> > */
> >
> > +#include <linux/errno.h>
> > #include <linux/types.h>
> > #include <linux/rcupdate.h>
> >
>
>

--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: X86: intel_ips, check for kzalloc properly
Next: [PATCH] X86: intel_ips, check for kzalloc properly