transhuge-memcg: some fixes (Re: Transparent Hugepage Support #25)
in [Kernel]
|
Prev: [PATCH v3 1/2] tmpfs: Add accurate compare function to percpu_counter library
Next: tmpfs: Make tmpfs scalable with percpu_counter for used blocks
From: Andrea Arcangeli on 17 Jun 2010 21:20 On Wed, Jun 02, 2010 at 02:44:38PM +0900, Daisuke Nishimura wrote: > These are trial patches to fix the problem(based on THP-25). > > [1/2] is a simple bug fix, and can be folded into "memcg compound(commit d16259c1 > at the http://git.kernel.org/?p=linux/kernel/git/andrea/aa.git)". > [2/2] is a main patch. > > Unfortunately, there seems to be some problems left, so I'm digging it and > need more tests. > Any comments are welcome. Both are included in -26, but like you said there are problems left... are you willing to fix those too? There's some slight difference in the code here and there that makes the fixes not so portable across releases (uncharge as param of move_account which wasn't there before as an example...). Thanks a lot for the help! Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Daisuke Nishimura on 18 Jun 2010 00:50
On Fri, 18 Jun 2010 03:08:40 +0200, Andrea Arcangeli <aarcange(a)redhat.com> wrote: > On Wed, Jun 02, 2010 at 02:44:38PM +0900, Daisuke Nishimura wrote: > > These are trial patches to fix the problem(based on THP-25). > > > > [1/2] is a simple bug fix, and can be folded into "memcg compound(commit d16259c1 > > at the http://git.kernel.org/?p=linux/kernel/git/andrea/aa.git)". > > [2/2] is a main patch. > > > > Unfortunately, there seems to be some problems left, so I'm digging it and > > need more tests. > > Any comments are welcome. > > Both are included in -26, but like you said there are problems > left... are you willing to fix those too? Will do if necessary, but hmm, I heard from KAMEZAWA-san that he has already sent some patches to fix the similar problems on RHEL6, and I prefer his fixes to mine. Should I(or KAMEZAWA-san?) forward port his patches onto current aa.git ? > There's some slight > difference in the code here and there that makes the fixes not so > portable across releases (uncharge as param of move_account which > wasn't there before as an example...). > Agreed. And I think you'll see some extra changes of memcg in 2.6.36... Any way, I'll do some test in both RHEL6 and aa.git when I have a time, and feel free to tell me if you have any troubles in back/forward porting memcg's fixes. Thanks, Daisuke Nishimura. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |