From: Jeff Dike on 20 Apr 2010 10:40 On Tue, Apr 20, 2010 at 06:09:49PM +0800, Amerigo Wang wrote: > On Mon, Apr 19, 2010 at 11:53:06PM +0200, Jan Kiszka wrote: > >We can't pull in linux/sched.h, so just declare the struct. > > > > Did you meet any build error? If yes, please include it. What does this patch fix, aside from being a bit cleaner? If it built before, without having a task_struct declaration, I think that means that the elf_core_copy_fpregs was never used. The task_struct * in the declaration would become a private task_struct, known only to the declaration. If the implementation or callers have the regular task_struct, it will be a different one, and the prototypes will conflict due to the different types of the first parameter. Jeff -- Work email - jdike at linux dot intel dot com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: [PATCH] globally ignore Module.symvers Next: Fix typo in percpu.h |